-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trezorctl: common exception handling #226
Labels
trezorlib
Python library and the command line trezorctl tool.
Comments
Yeah I agree. It's terrible the way it is. Electrum and Electron Cash both have horrible UX's as a result. |
yeah no, that's completely unrelated. these apps are using trezor as a library and can do their own exception handling, so if there's terrible UX that's their problem this issue is specifically about bad exception handling in |
Ok, I'll shut up now. :) |
matejcik
added a commit
that referenced
this issue
Mar 24, 2020
matejcik
added a commit
that referenced
this issue
Mar 25, 2020
matejcik
added a commit
that referenced
this issue
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, every command has to handle its own exceptions. So most canceled actions throw a stack trace, unless specifically coded against.
That is stupid.
We should have a common exception handler for the subcommands and output nice messages whenever it makes sense.
Also maybe stop for a minute and rethink raising exceptions when an action is canceled?
The text was updated successfully, but these errors were encountered: