Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trezorctl: common exception handling #226

Closed
matejcik opened this issue Jun 7, 2018 · 3 comments
Closed

trezorctl: common exception handling #226

matejcik opened this issue Jun 7, 2018 · 3 comments
Assignees
Labels
trezorlib Python library and the command line trezorctl tool.

Comments

@matejcik
Copy link
Contributor

matejcik commented Jun 7, 2018

Currently, every command has to handle its own exceptions. So most canceled actions throw a stack trace, unless specifically coded against.

That is stupid.

We should have a common exception handler for the subcommands and output nice messages whenever it makes sense.

Also maybe stop for a minute and rethink raising exceptions when an action is canceled?

@matejcik matejcik self-assigned this Jun 7, 2018
@cculianu
Copy link

cculianu commented Apr 2, 2019

Yeah I agree. It's terrible the way it is. Electrum and Electron Cash both have horrible UX's as a result.

@matejcik
Copy link
Contributor Author

matejcik commented Apr 3, 2019

yeah no, that's completely unrelated. these apps are using trezor as a library and can do their own exception handling, so if there's terrible UX that's their problem

this issue is specifically about bad exception handling in trezorctl the CLI tool

@cculianu
Copy link

cculianu commented Apr 3, 2019

Ok, I'll shut up now. :)

@matejcik matejcik transferred this issue from trezor/python-trezor Jun 5, 2019
@matejcik matejcik added feature trezorlib Python library and the command line trezorctl tool. labels Jun 5, 2019
@matejcik matejcik added this to the backlog milestone Jun 5, 2019
@ZdenekSL ZdenekSL added the W3 label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trezorlib Python library and the command line trezorctl tool.
Projects
None yet
Development

No branches or pull requests

3 participants