feat(core/cardano): Implement bech32 asset ids based on CIP-0014 #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging into a Cardano branch, will merge to master once CI checks go through |
|
in master now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: CIP-0014 specifying a human-readable token fingerprint has reached a consensus, it has been picked up by block explorers such as cardanoscan.io already, hence we are updating Trezor's UI to show it instead of the raw token policy id and name (which may or may not be printable)
Changes:
Testing:
pytest tests/device_tests -k "test_cardano_sign_tx"passesmake test_emu_ui_recordAffected UI fixtures before: https://drive.google.com/drive/u/0/folders/1n2nHWf7ssMOPzrxW5cHsZKrxiHdF0cnf
Affected UI fixtures after: https://drive.google.com/drive/u/0/folders/1jNKn3ts-txOYhjySaM6wbAny4kCm8O6j