Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust UI: keyboards tweaks and fixes #2154

Merged
merged 5 commits into from
Mar 23, 2022
Merged

Rust UI: keyboards tweaks and fixes #2154

merged 5 commits into from
Mar 23, 2022

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 4, 2022

Fixes #2142. Obsoletes #2104.

emu00000000 emu00000001 emu00000002 emu00000003 emu00000004 emu00000005 emu00000006 emu00000007 emu00000008 emu00000009

Missing:

  • return entered sequence (needs Rust UI: improve messages returned to python #2138)
  • fix for visual glitches caused by overlapping Maybes (needs Honza's placement code)
  • long PINs and passphrases
  • show wrong pin warning (needs ability to start timer on layout init)
  • funny button shape in PIN keyboard

@mmilata mmilata mentioned this pull request Mar 4, 2022
Closed
35 tasks
@matejcik
Copy link
Contributor

matejcik commented Mar 4, 2022

on image 1 the "disabled OK" button looks bad. IIRC the checkmark should be white (despite being disabled)

@mmilata mmilata changed the base branch from master to dynamic_place March 17, 2022 14:19
@matejcik matejcik force-pushed the dynamic_place branch 2 times, most recently from 53c9c1b to 432084b Compare March 22, 2022 14:22
Base automatically changed from dynamic_place to master March 22, 2022 15:08
@matejcik
Copy link
Contributor

please rebase (or maybe just cherry-pick?) onto current master

@mmilata mmilata marked this pull request as ready for review March 23, 2022 11:14
@prusnak
Copy link
Member

prusnak commented Mar 23, 2022

on image 1 the "disabled OK" button looks bad. IIRC the checkmark should be white (despite being disabled)

Shall we even show the Confirm button in case it is disabled?

matejcik
matejcik reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to run UI2 ui tests as a separate CI job?

core/embed/rust/src/ui/model_tt/component/keyboard/pin.rs Outdated Show resolved Hide resolved
@mmilata mmilata merged commit c8dda32 into master Mar 23, 2022
@mmilata mmilata deleted the mmilata/tt-keyboards branch March 23, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboards for seed restore
3 participants
@mmilata @matejcik @prusnak