fix(core): add missing semicolon into the passphrase choice for TS3

[grdddj]

Fixes #3476:

• adds semicolon character as a passphrase choice

TODO:

• record the changed UI tests (if any)
• consider whether to add a changelog entry

[prusnak]

What is the sort order of the special characters? Is it the same as on Trezor Model T?

[grdddj]

What is the sort order of the special characters? Is it the same as on Trezor Model T?

Yeah, the order should be the same - I have somehow omitted the semicolon for TS3 in the past:

trezor-firmware/core/embed/rust/src/ui/model_tt/component/keyboard/passphrase.rs

Line 39 in c09f9e8

["_<>", ".:@", "/|\\", "!()", "+%&", "-[]", "?{}", ",'`", ";\"~", "$^="],

trezor-firmware/core/embed/rust/src/ui/model_tr/component/input_methods/passphrase.rs

Line 34 in c09f9e8

const SPECIAL_SYMBOLS: &str = "_<>.:@/|\\!()+%&-[]?{},\'`\"~$^=*#";

No idea from where the order came from, seems historical reasons

NOTE: on TT, the *# characters are part of the alphabetical part

[Hannsek]

@prusnak do you have some position change in your mind?

[prusnak]

@prusnak do you have some position change in your mind?

No. I was just curious.

[bosomt]

QA OK

Info:

• Suite version: desktop 24.1.1 (c4cf80383d5f554ff118ba507b743074e73216d4)
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.1.1 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
• OS: MacIntel
• Screen: 1512x982
• Device: Trezor T2B1 2.6.5 regular (revision 988ba0b)
• Transport: BridgeTransport 2.0.33