Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations improvements #3531

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Translations improvements #3531

merged 13 commits into from
Feb 21, 2024

Conversation

grdddj
Copy link
Contributor

@grdddj grdddj commented Feb 12, 2024

Follow up on translations - smaller fixes, documentation, tests, newer translations strings, etc.

@grdddj grdddj force-pushed the grdddj/translations_improvements branch from 5eb3908 to 8bc8f9a Compare February 13, 2024 10:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

core UI changes device test click test persistence test
Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
Model Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@grdddj grdddj force-pushed the grdddj/translations_improvements branch from dcf277e to 14e7104 Compare February 20, 2024 08:16
@grdddj grdddj marked this pull request as ready for review February 20, 2024 11:52
@grdddj grdddj requested review from mmilata and removed request for prusnak and matejcik February 20, 2024 11:52
mmilata
mmilata approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly low-profile changes anyway.

grdddj and others added 12 commits February 21, 2024 10:10
@grdddj
chore(python): include error when wanting to upload a JSON file as a …
1c2bd86 
…translation payload

[no changelog]
@grdddj
chore(core): add missing template to the variable name
c56aecb 
[no changelog]
@grdddj
docs(core): add documentation for translations
2d43415 
[no changelog]
@grdddj
chore(core): catch possible EOFError when parsing translations header
eabb828 
[no changelog]
@grdddj
feat(tests): create test for silent language updates
f5a6ed4 
[no changelog]
@grdddj
feat(tests): fix and extend translations tests
9e25601 
[no changelog]
@mmilata @grdddj
docs(core): document translations blob format
6c6a0b7 
[skip_ci]
@grdddj
feat(core): add newly translated strings from agency
31bc57c 
[no changelog]
@grdddj
fix(core): shorten long translations
b5e26cd 
[no changelog]
@grdddj
fix(core): replace spanish number symbol with nro. shortcut
7fc994d 
[no changelog]
@grdddj
chore(tools): add rules for buttons and new strings
96506f3 
[no changelog]
@grdddj
chore(core): generate signatures.json
c2f01d8 
[no changelog]
@grdddj grdddj force-pushed the grdddj/translations_improvements branch from 8b0459c to 4ca6161 Compare February 21, 2024 09:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@grdddj grdddj force-pushed the grdddj/translations_improvements branch from 4ca6161 to 9f9d1c5 Compare February 21, 2024 10:15
@grdddj grdddj force-pushed the grdddj/translations_improvements branch from 9f9d1c5 to 116a73a Compare February 21, 2024 10:46
@grdddj grdddj merged commit 4204ba1 into main Feb 21, 2024
59 of 61 checks passed
@grdddj grdddj deleted the grdddj/translations_improvements branch February 21, 2024 11:44
@mmilata mmilata mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grdddj @mmilata @matejcik