Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/ethereum): use BIP44 variant to detect ETH account # #4117

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(core/ethereum): use BIP44 variant to detect ETH account # #4117

merged 1 commit into from
Sep 16, 2024

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Aug 22, 2024 •
edited
Loading

Fixes #3627

@ibz ibz self-assigned this Aug 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@Hannsek
Copy link
Contributor

Hannsek commented Aug 22, 2024

@ibz "Refs" doesn't work when linking issues. You have to use one of these.

@ibz ibz marked this pull request as ready for review August 22, 2024 12:57
@ibz ibz requested a review from matejcik as a code owner August 22, 2024 12:57
@ibz ibz mentioned this pull request Sep 13, 2024
Merged
obrusvit
obrusvit approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

However, there's no active UI test for Account info in ETH.

@ibz ibz force-pushed the ibz/20240822-eth-account branch 2 times, most recently from a302463 to df44a50 Compare September 13, 2024 08:25
@ibz ibz added the translations Put this label on a PR to run tests in all languages label Sep 13, 2024
@ibz ibz merged commit 4e0851d into main Sep 16, 2024
128 of 130 checks passed
@ibz ibz deleted the ibz/20240822-eth-account branch September 16, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik matejcik approved these changes

Assignees

@ibz ibz

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account under "i" in receive flow is always 'ETH #1', regardless of derivation path
4 participants
@ibz @Hannsek @matejcik @obrusvit