Create an enum for valid device rotations #4125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieleluk
changed the title
matejcik
reviewed
Aug 27, 2024
| label = TR.rotation__west | ||
| else: | ||
| raise DataError("Unsupported display rotation") | ||
| raise ValueError(f"Unsupported display rotation: {rotation}") |
There was a problem hiding this comment.
use a RuntimeError here, this cannot happen because your if/elif is exhaustive
also don't use generic errors with texts https://docs.trezor.io/trezor-firmware/core/misc/exceptions.html
dtto below
bieleluk
force-pushed
the
rotation-enum
branch
from
5d07343
to
7694c74
Compare
matejcik
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4041