Suspend to lower power mode on T3W1 #4454
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
|
[no changelog]
[no changelog]
[no changelog]
[no changelog]
cepetr
force-pushed
the
cepetr/powerctl-suspend
branch
from
289536e to
2e41fe6
Compare
TychoVrahe
reviewed
Dec 20, 2024
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| #include "../../display_internal.h" | |||
|
|
|||
| #pragma GCC optimize("-O0") | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #pragma GCC optimize("-O0") |
| @@ -93,6 +95,10 @@ void powerctl_suspend(void) { | |||
| // immediately after exiting STOP2 mode. | |||
| irq_key_t irq_key = irq_lock(); | |||
|
|
|||
| // Enable PWR peripheral clock | |||
| // (required by the following HAL_PWREx_EnterSTOP2Mode) | |||
| __HAL_RCC_PWR_CLK_ENABLE(); | |||
There was a problem hiding this comment.
maybe we should disable after waking up? (it is enabled again in SystemInit and then disabled, so end effect zero, but it is not very clear from this function here)
| @@ -150,6 +154,15 @@ STATIC mp_obj_t mod_trezorio_poll(mp_obj_t ifaces, mp_obj_t list_ref, | |||
| #if USE_BUTTON | |||
| else if (iface == BUTTON_IFACE) { | |||
| const uint32_t evt = button_get_event(); | |||
|
|
|||
| // --- experimental --- | |||
| #ifdef USE_POWERCTL | |||
| void optiga_hal_deinit(void) { | ||
| GPIO_InitTypeDef GPIO_InitStructure = {0}; | ||
|
|
||
| GPIO_InitStructure.Mode = GPIO_MODE_ANALOG; |
There was a problem hiding this comment.
As setting pins as ANALOG when shutting down or going to low power is frequently repeating, maybe we could introduce some helper function for this, maybe in powerctl driver or introduce a gpio driver. Not very important, but it would save some typing and would be easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of suspending and resuming to/from low power mode on T3W1, aiming to achieve the lowest possible power consumption.
It enhances the initialization and deinitialization of the following drivers to enable achieving the lowest power consumption in STOP2 mode:
ltd_dsidisplay driver (used only on T3W1 and disc2)backlight_pwm(used on also on T and T3T1 models)drv2625driverbuttondriverdma2ddriverAdds new POWERCTL_SUSPEND syscall
Introduces a new
USE_USBfeature utilized in the boardloader code.Adds a return value for the
display_init()function, although it is not yet used anywhere.