Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cstyle and editor_check inconsistency #4676

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

kopecdav
Copy link

If you create a .c or .h file with CRLF EOL sequence make cstyle_check wont recognize any issue nor fix anything with make cstyle command.

On the other hand make editor_check will fails with error:

Wrong line endings or no final newline
Not all lines have the correct end of line character

this PR fix the clang-format to enforce LF EOL sequence, so make cstyle command will deal with this automatically.

@kopecdav kopecdav self-assigned this Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@kopecdav kopecdav force-pushed the kopecdav/cstyle_check_update_EOF branch from 13888c0 to 7a2ca17 Compare February 25, 2025 14:10
@kopecdav kopecdav merged commit 36abb9b into main Feb 25, 2025
96 checks passed
@kopecdav kopecdav deleted the kopecdav/cstyle_check_update_EOF branch February 25, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants