Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Tests ] Cypress: element is detached from the DOM error #1046

Closed
1 of 2 tasks
mroz22 opened this issue Jan 10, 2020 · 0 comments
Closed
1 of 2 tasks

[ Tests ] Cypress: element is detached from the DOM error #1046

mroz22 opened this issue Jan 10, 2020 · 0 comments

Comments

@mroz22
Copy link
Contributor

mroz22 commented Jan 10, 2020

This is reported in cypress repo cypress-io/cypress#5743

Started to appear after we upgraded to Cypress 3.7.0. Appears only on local test run, does not affect CI.

This is a common error covered by Cypress documentation, https://docs.cypress.io/guides/references/error-messages.html#cy-failed-because-the-element-you-are-chaining-off-of-has-become-detached-or-removed-from-the-dom
but I believe that we are not the case mentioned there. We use cy.get().click() directly one after another.

TODO:

  • test if rollback to 3.4 version helps
  • test if update to 3.8.1 (latest) helps does not help
mroz22 added a commit that referenced this issue Jan 10, 2020
New modals logic do not require hiding "exit" button from onboarding if device is not ready to work with.
It also somewhat mitigates #1046 Seems like if there are less renders, the chance it happens is smaller.
mroz22 added a commit that referenced this issue Jan 13, 2020
New modals logic do not require hiding "exit" button from onboarding if device is not ready to work with.
It also somewhat mitigates #1046 Seems like if there are less renders, the chance it happens is smaller.
vladimirvolek pushed a commit that referenced this issue Jan 13, 2020
* onboarding exit button always visible

New modals logic do not require hiding "exit" button from onboarding if device is not ready to work with.
It also somewhat mitigates #1046 Seems like if there are less renders, the chance it happens is smaller.

* less unit test-like approach

acting like unit writing unit tests is considered antipattern, see here https://docs.cypress.io/guides/references/best-practices.html#Creating-%E2%80%9Ctiny%E2%80%9D-tests-with-a-single-assertion other way round it gives us performance boost

* clean up onboarding tests
@mroz22 mroz22 closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant