-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make e2e tests work on arm #3616
Comments
The tests really heavily on the trezor-user-env docker image which must be adapted for arm in the first place. (running the x86 version fails due to NixOS/nix#4485 or rather docker/for-mac#5204). That, in turn, will require arm64 binaries of the emulator and the bridge and arm64 version of the nix image. For that last there's already an issue. A good guide on maiking multi-arch docker images seems to be this one. |
That's a bummer :(. I know @prusnak is using Nix natively without Docker so trezor-user-env might work natively on M1. But we would have to alter the e2e tests then not to use trezor-user-env in docker but directly. There is some work needed and since it is just a hypothesis and I am not sure it is worth it :(. |
1.4 release doesn't provide builds for arm64. Bump to the latest version (1.12) which does.
1.4 release doesn't provide builds for arm64. Bump to the latest version (1.12) which does.
1.4 release doesn't provide builds for arm64. Bump to the latest version (1.12) which does.
This will have to wait for someone else. |
@vdovhanych is this still valid? |
@hynek-jina This is still being worked on but should be resolved for the most part. So i would leave it until we're finished in trezor-user-env |
@ondracja Are you able to run the Cypress tests on an M1? If so, could you please update https://github.com/trezor/trezor-suite/blob/develop/docs/tests/e2e-suite-web.md or write down the difference from the current instructions in this thread? We could then close this issue. |
@komret Yes, I'm able to run cypress directly (I use docker only for |
Since the README update is now merged, I'm closing this issue. |
QA OK :) |
Currently the e2e setup doesn't work out of the box on arm machines (eg. M1 macs). Fix this to make it easy for anyone with arm machine to run e2e tests locally.
This will require several steps some of which need to be done in other repositories. (trezor-user-env, trezord-go, ...). This issue serves as a place to track all these steps leading to seamless e2e tests on M1 macs.
Assigning myself to work on this gradually over time.
The text was updated successfully, but these errors were encountered: