test(suite-native): Import an already imported XPUB #12518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrcj
suggested changes
May 27, 2024
| @@ -23,6 +23,19 @@ class AccountImportActions { | |||
| await scrollUntilVisible(by.text(accountName)); | |||
| } | |||
|
|
|||
| async importSameAccount({ | |||
There was a problem hiding this comment.
this method is unnecessary, pls use importAccount for this test's purposes.
| }) { | ||
| await this.selectCoin({ networkSymbol }); | ||
| await this.submitXpub({ xpub, isValid: true }); | ||
| await detoxExpect(element(by.text('Coin already synced'))).toBeVisible(); |
There was a problem hiding this comment.
While onging expects are fine inside a page action method (eg if you want to assert/wait for something during the test), this is the final assert of the test which should always be in the IT part of the test, not iside the logic
Nodonisko
requested changes
May 27, 2024
|
@Nodonisko you are right, i have not noticed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatized tests of sanity test Import an already imported XPUB
https://www.notion.so/satoshilabs/Import-an-already-imported-XPUB-c15497dd8e3340618c17029745f11aab?pvs=4