Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/matic pol #14093

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Feat/matic pol #14093

merged 2 commits into from
Sep 27, 2024

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Sep 3, 2024 •
edited
Loading

Description

  • change matic -> pol
  • migration of suite settings matic -> pol

Related Issue

resolve #14589

Screenshots:

Screenshot 2024-09-03 at 13 45 22

@tomasklim tomasklim marked this pull request as draft September 3, 2024 11:48
@jvaclavik
Copy link
Contributor

jvaclavik commented Sep 3, 2024 •
edited
Loading

Screenshot 2024-09-03 at 13 45 22

btw you can use

<Warning.Button textWrap={false}>...</Warning.Button>

to prevent text wrapping in Warning.

jvaclavik
jvaclavik approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jvaclavik jvaclavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DS-related stuff ✅

mroz22
mroz22 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect part looks ok

@tomasklim tomasklim marked this pull request as ready for review September 5, 2024 15:00
vytick
vytick approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile related stuff looks good 👍

@bosomt

This comment was marked as outdated.

Sign in to view
@tomasklim tomasklim added the blocked Blocked by external force. Third party inputs required. label Sep 8, 2024
@MiroslavProchazka MiroslavProchazka mentioned this pull request Sep 9, 2024
Closed
3 tasks
@FreeWall
Copy link
Member

coingeckoNativeId in networksConfig.ts should be polygon-ecosystem-token
https://www.coingecko.com/en/coins/polygon-ecosystem-token

@tomasklim tomasklim force-pushed the feat/matic-pol branch 5 times, most recently from 06040cb to c927bd7 Compare September 26, 2024 19:55
@tomasklim tomasklim removed the blocked Blocked by external force. Third party inputs required. label Sep 27, 2024
@marekrjpolak
Copy link
Contributor

the migration stops here and does not continue, any idea why?

The relevant part looks good now, so miniapprove from me 👍

@LukasRada LukasRada mentioned this pull request Sep 27, 2024
Merged
@tomasklim tomasklim merged commit 44ef9e9 into develop Sep 27, 2024
84 checks passed
@tomasklim tomasklim deleted the feat/matic-pol branch September 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekrjpolak marekrjpolak marekrjpolak left review comments

@mroz22 mroz22 mroz22 approved these changes

@vytick vytick vytick approved these changes

@jvaclavik jvaclavik jvaclavik approved these changes

@Nodonisko Nodonisko Awaiting requested review from Nodonisko Nodonisko is a code owner

@adamhavel adamhavel Awaiting requested review from adamhavel adamhavel is a code owner

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MATIC to POL
7 participants
@tomasklim @jvaclavik @bosomt @FreeWall @marekrjpolak @vytick @mroz22