chore(suite-native): capture console errors to sentry on mobile too #14439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejkriz
commented
Sep 19, 2024
| @@ -107,7 +107,6 @@ | |||
| "electron": "30.3.1", | |||
| "@types/node": "20.12.7", | |||
| "@types/react": "18.2.55", | |||
| "@sentry/types": "7.92.0", | |||
There was a problem hiding this comment.
I just removed this resolution and typescript wasn't complaining, so I guess it's not needed anymore.
Nodonisko
approved these changes
Sep 19, 2024
matejkriz
force-pushed
the
chore/native/sentry-capture-consoler-errors
branch
from
08da049
to
036fe2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Desktop Suite reports console.error to Sentry, but mobile not yet. But console.error is used also on some places in shared common code instead of throwing an error like for example parsing message system config, so we miss those errors.
Example test error: https://satoshilabs.sentry.io/issues/5873989872/?environment=debug&project=4504214699245568&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=90d&stream_index=0