Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite-native): send navigation improvements #14464

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat(suite-native): send navigation improvements #14464

merged 1 commit into from
Sep 24, 2024

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Sep 23, 2024

Description

  • the send button is removed from dashboard (It will stay this way until we do not support send for all the networks)
  • user is able to enter the send flow from the account detail --> redirect directly to the send form (with particular account selected)
  • user is not allowed to entry the send flow from portfolio tracker accounts
  • If user clicks on a close button while is on device review in progress, he is redirected to the place from where he entered the send flow (account detail ATM)

Related Issue

Resolve #13765

Screenshots:

Screenshot 2024-09-23 at 10 36 49

@PeKne PeKne added the mobile Suite Lite issues and PRs label Sep 23, 2024
@PeKne PeKne requested a review from a team as a code owner September 23, 2024 08:38
@PeKne PeKne force-pushed the feat/native/send-navigation-improvements branch from e7a0611 to 43d095a Compare September 23, 2024 11:33
vytick
vytick approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 👌

suite-native/module-accounts-management/src/components/TransactionListHeader.tsx Outdated
const isSendButtonDisplayed =
isSendEnabled &&
SEND_NETWORK_WHITELIST.includes(account.symbol) &&
!isTokenDetail &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isTokenDetail is probably not needed there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it there intentionally. But you are right that when we enable ETH or other tokens supporting coin, we will definitely revisit this piece of code. So no need to handle it now. Removed in d408816.

@PeKne
Copy link
Contributor Author

PeKne commented Sep 24, 2024

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11008304336

@trezor-ci trezor-ci force-pushed the feat/native/send-navigation-improvements branch from d408816 to 36b53c2 Compare September 24, 2024 06:33
@PeKne PeKne merged commit 8d2dbbe into develop Sep 24, 2024
48 of 88 checks passed
@PeKne PeKne deleted the feat/native/send-navigation-improvements branch September 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send coins - navigation improvements
2 participants
@PeKne @vytick