Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): send confirm on device bottom sheet #14477

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Sep 23, 2024

Related Issue

Resolve #13965

@PeKne PeKne added the mobile Suite Lite issues and PRs label Sep 23, 2024
@PeKne PeKne requested a review from a team as a code owner September 23, 2024 11:37
@PeKne PeKne force-pushed the fix/native/send-confirm-on-device-bottom-sheet branch 2 times, most recently from 4925d73 to c50c4c5 Compare September 23, 2024 12:38
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@@ -1,13 +1,18 @@
import { BottomSheet, Button, VStack, Box, Text } from '@suite-native/atoms';
import { Translation } from '@suite-native/intl';
import { ReactNode } from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: there are some linting errors not catched by checks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed (already squashed).

@PeKne PeKne force-pushed the fix/native/send-confirm-on-device-bottom-sheet branch from c50c4c5 to 8aa97b0 Compare September 24, 2024 06:33
@PeKne PeKne merged commit 1d40223 into develop Sep 24, 2024
14 checks passed
@PeKne PeKne deleted the fix/native/send-confirm-on-device-bottom-sheet branch September 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send coins - ConfirmOnTrezorImage customization
2 participants