Feat/empty device label #14483
Merged
Feat/empty device label #14483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
force-pushed
the
feat/empty-device-label
branch
from
4182e20
to
2a16aa2
Compare
komret
requested review from
a team,
mroz22,
szymonlesisz and
martykan
as code owners
Nodonisko
reviewed
Sep 23, 2024
Lemonexe
reviewed
Sep 24, 2024
packages/suite/src/components/suite/notifications/NotificationRenderer/NotificationRenderer.tsx
Outdated
Show resolved
Hide resolved
Lemonexe
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Tested with physical trezor and onboarding works fine ✔️
I tested some of the usages selectDeviceLabelOrName and they work fine, so I'd trust the others ✔️
Codewise LGTM, though with comment above 💬
Lemonexe
approved these changes
Sep 24, 2024
|
/rebase |
|
Rebasing failed, please rebase manually. |
komret
force-pushed
the
feat/empty-device-label
branch
from
e6ecafe
to
2f9491d
Compare
matejkriz
added a commit
that referenced
this pull request
Oct 15, 2024
- #14483 broke device label in case of multiple devices. Device label of selected device was reused for all of them.
matejkriz
added a commit
that referenced
this pull request
Oct 15, 2024
- #14483 broke device label in case of multiple devices. Device label of selected device was reused for all of them.
komret
pushed a commit
that referenced
this pull request
Nov 14, 2024
- #14483 broke device label in case of multiple devices. Device label of selected device was reused for all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #12881
Screenshots:
Before:
After:
This is not value but placeholder: