Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-desktop): fix bridge controls in debug menu #14539

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Sep 26, 2024

image

fixing bridge controls in debug menu. this feature might be useful for some old T ones edgecase handling - turning on legacy bridge instead of the new bridge in the runtime of application. cc @MiroslavProchazka that we are able to achieve that, eg we detected unreadable device, we give you a button "use old bridge".

resolve #13587

Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I think it's okay to split the init code just for bridge, since it's handled in a special way due for autostart.

@mroz22 mroz22 marked this pull request as ready for review September 27, 2024 11:32
@mroz22
Copy link
Contributor Author

mroz22 commented Sep 27, 2024

My main concern is that I might be doing some non-systematic changes in code that you guys, mainly @marekrjpolak won't like. On the other hand if it get its job done, lets move on and talk about improvements later

@mroz22 mroz22 merged commit b88e96f into develop Sep 27, 2024
22 checks passed
@mroz22 mroz22 deleted the bridge-controls-desktop branch September 27, 2024 11:52
@marekrjpolak
Copy link
Contributor

mainly @marekrjpolak won't like

I won't pretend that I'm not gonna cry because of this. But let's just stop calling Bridge (and maybe even Tor) modules as they're handled on their own, and I'll be quite happy.

In the future, we may for example separate the Bridge & Tor process logic (which will be handled purely in the main) from control which can be handled as before (=> it will become module again?). Anyway, this is good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suite-desktop debug: bridge running switch
3 participants