Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite-web): use data.trezor.io for FW hash check #15508

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(suite-web): use data.trezor.io for FW hash check #15508

wants to merge 1 commit into from
+10 −7

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Nov 21, 2024 •
edited by peter-sanderson
Loading

Description

Currently suite-web downloads FW binary for FW hash check from suite.trezor.io, where only some binaries are available, and it cannot be relied upon.

➡️ switch to data.trezor.io where all binaries are available so all supported versions can be checked

QA instructions

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 11
  • More info

Learn more about 𝝠 Expo Github Action

@Lemonexe Lemonexe marked this pull request as ready for review November 21, 2024 18:40
@Lemonexe
Copy link
Contributor Author

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11970867538

@trezor-ci trezor-ci force-pushed the feat/fw-hash-check-from-data-on-web branch from 65dba8d to 4230283 Compare November 22, 2024 10:29
mroz22
mroz22 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok did not test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-sanderson peter-sanderson peter-sanderson approved these changes

@mroz22 mroz22 mroz22 approved these changes

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lemonexe @mroz22 @peter-sanderson