fix(e2e): Resolve local fails of core tests #15566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HajekOndrej
approved these changes
Nov 25, 2024
These tests are passing without an issue on CLI Conditionaly skiping local runs of 'EAP test'. Adding issue to backlog Annoting dependency of 'Electrum completes discovery successfully'
Vere-Grey
force-pushed
the
fix-failing-local-tests
branch
from
e843976 to
8a71daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few tests are passing without an issue on CLI but failing in local runs.
I have added a conditionaly skipping local runs of 'EAP test'. Adding issue to backlog
I have added annotation of dependency to 'Electrum completes discovery successfully' test. I have found out you need RegTest running locally. I have mentioned this also in docs
Minor refactoring
Added tracing for electron window. I would like to discuss that.