Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdin translations update #16812

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

trezor-ci
Copy link
Contributor

Automatically generated PR for updating crowdin translations.

@trezor-ci trezor-ci added the translations Improvement of derived (non-ENG) copy label Feb 4, 2025
Copy link

coderabbitai bot commented Feb 4, 2025

Walkthrough

This pull request introduces additional translation keys to the English translations file that pertain to device security and transaction address verification. Specifically, a new key for indicating a compromised device authenticity check is added, and a series of keys provide step-by-step instructions for verifying the recipient address. Additionally, existing translation messages in the support messages file have been rephrased for improved clarity, detailing actions such as navigating to the source where the original address was obtained, comparing the address shown on the device, and confirming the match. No changes were made to the declarations of exported or public entities beyond these updates.

Possibly related PRs

Suggested reviewers

  • MiroslavProchazka
  • komret
  • tomasklim

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80064fe and 71808c6.

📒 Files selected for processing (2)
  • packages/suite-data/files/translations/en.json (2 hunks)
  • packages/suite/src/support/messages.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/suite/src/support/messages.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: build-web
  • GitHub Check: build-web
🔇 Additional comments (2)
packages/suite-data/files/translations/en.json (2)

680-680: New Device Authentication Failure Message
The new key "TR_DEVICE_COMPROMISED_DEVICE_AUTHENTICITY_TEXT" is added with a clear, concise message ("Your device authentication check failed.") that is consistent in tone and format with the similar device verification messages.


1550-1554: New Address Confirmation Translation Keys
These keys provide step‑by‑step instructions for verifying a recipient address:

  • "TR_SEND_ADDRESS_CONFIRMATION_HEADING" sets the context by alerting users to verify the address.
  • "TR_SEND_ADDRESS_CONFIRMATION_ITEM_1_HEADING", "TR_SEND_ADDRESS_CONFIRMATION_ITEM_2_HEADING", and "TR_SEND_ADDRESS_CONFIRMATION_ITEM_3_HEADING" give clear, sequential steps for checking the source, comparing on-device, and confirming the match.
  • "TR_SEND_ADDRESS_CONFIRMATION_NOTE" reinforces the need for an exact match.

They are well‑phrased and align with the recent rewordings in the support messages. Please confirm that the associated UI components in packages/suite/src/support/messages.ts use these keys correctly.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@komret komret enabled auto-merge (rebase) February 4, 2025 14:29
@komret komret merged commit 8e3f46b into develop Feb 4, 2025
31 of 32 checks passed
@komret komret deleted the trezor-ci/crowdin-sync-1738678909 branch February 4, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Improvement of derived (non-ENG) copy
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants