[SYCL][XOCC] Add multi-file and split compilation support. #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralender
force-pushed
the
SplitCompilation
branch
from
0dd70ab to
9765891
Compare
keryell
requested changes
Dec 4, 2020
Member
keryell
left a comment
keryell
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Just a few nitpicks...
| if (P.second->getTriple().isXilinxFPGA()) | ||
| return false; | ||
|
|
||
| // Right off the bat, assume the presense of -foffload-static-lib means |
Member
There was a problem hiding this comment.
Suggested change
| // Right off the bat, assume the presense of -foffload-static-lib means | |
| // Right off the bat, assume the presence of -foffload-static-lib means |
Contributor
Author
There was a problem hiding this comment.
This code is from intel so i don't think modifying it even a typo is good idea because it increases likelihood of conflicts.
| cl::sycl::range<1> NumOfWorkItems{Buffer.get_count()}; | ||
| Queue.submit([&](cl::sycl::handler &cgh) { | ||
| sycl::accessor Accessor(Buffer, cgh, sycl::write_only); | ||
| cgh.single_task<class Test1>([=]() { Accessor[0] = 0; }); |
Member
There was a problem hiding this comment.
Suggested change
| cgh.single_task<class Test1>([=]() { Accessor[0] = 0; }); | |
| cgh.single_task<class Test1>([=] { Accessor[0] = 0; }); |
| Queue.submit([&](cl::sycl::handler &cgh) { | ||
| sycl::accessor Accessor(Buffer, cgh, sycl::write_only); | ||
| cgh.single_task<class Test2>( | ||
| [=]() { Accessor[0] = 0; }); |
Member
There was a problem hiding this comment.
Suggested change
| [=]() { Accessor[0] = 0; }); | |
| [=] { Accessor[0] = 0; }); |
| static_cast<const toolchains::XOCCToolChain &>(getToolChain()); | ||
| InputInfoList SyclXoccArg = Inputs; | ||
|
|
||
| if (Inputs.size() > 1) { |
Member
There was a problem hiding this comment.
Add a comment explaining the high-level behaviour
Ralender
force-pushed
the
SplitCompilation
branch
from
9765891 to
e6be9a0
Compare
Member
|
@Ralender what is the status of this PR? |
Contributor
Author
|
I think it should be good to merge. unless you have any objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.