react-hot-loader v3 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!! I'll review this weekend! Thanks!! 💃 |
tribou
requested changes
Oct 13, 2017
| @@ -16,7 +16,8 @@ | |||
| "test": { | |||
| "plugins": [ | |||
| "transform-class-properties", | |||
| "transform-object-assign" | |||
| "transform-object-assign", | |||
| "react-hot-loader/babel" | |||
There was a problem hiding this comment.
Is this working? I think this only adds it if NODE_ENV=test
We might want to make a separate "development" property for the dev plugins like this one and see how that works
| @@ -17,6 +17,7 @@ function getEntry (entry/* : ?(string | Object | Array<*>) */) { | |||
| return { | |||
| entry: { | |||
| bundle: [ | |||
| 'react-hot-loader/patch', | |||
There was a problem hiding this comment.
it may not be as clean to do this here, but we should probably only add this if NODE_ENV === 'development'
|
|
||
| }) | ||
|
|
||
| } |
There was a problem hiding this comment.
Did you try out the new relaxed arrow function lint rules?? ...we can now do this: 😉
if (module.hot) module.hot.accept('src/routes', () => render(App))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably gotta fix the HMR issue you mentioned first, but I figured I'd submit this while I have it 👍