Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and documented pip support for installing packages. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Paul-dH
Copy link

@Paul-dH Paul-dH commented Oct 16, 2020

I run HA in a docker environment and wanted to use HACS. Therefore I added pip support to the script and tested it.

Thought I'd share the addition to the script :)

@tribut
Copy link
Owner

tribut commented Oct 16, 2020

Thanks for your contribution!
Can you explain the use-case a bit more for me? Python packages should be installed by Homeassistant automatically according to the requirements of the respective compontents. I use HACS myself, and aiogithubapi (and others) are installed just fine.

@tribut tribut added the enhancement New feature or request label Oct 16, 2020
@Paul-dH
Copy link
Author

Paul-dH commented Oct 16, 2020

No problem :)

I'm currently busy setting up HA in docker on a Ubuntu server behind a reverse proxy. I kept getting permission errors so I landed at the community post where this repo was mentioned. After I changed the composefile and added the run script I saw that HA booted up and the only thing that failed were the python packages. That's why I added the ${PIP} part.

My composefile is like this:

version: '3.6'

services:
  homeassistant:
    image: homeassistant/home-assistant:stable
    container_name: home-assistant
    hostname: home-assistant
    restart: always
    ports:
      - '8123:8123'
      - '8943:8943'
    volumes:
      - ./config:/config
      - ./config/docker/run:/etc/services.d/home-assistant/run
    environment:
      - PUID=1000
      - PGID=1000
      - UMASK=007
      - PIP=aiogithubapi
    networks:
      - proxy-tier

networks:
  proxy-tier:
    external:
      name: proxy-tier

@tribut
Copy link
Owner

tribut commented Jul 14, 2021

I've tried to use your config, but cannot reproduce the problem. Have you by chance tried again without your changes since?
I understand this PR has been open a very long time, but since nobody else seems to be having problems with pip-packages I am really hesitant to add this without understanding what goes wrong...

@tribut tribut added the question Further information is requested label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants