Skip to content

Conversation

Copy link

Copilot AI commented Nov 29, 2025

The bundled am-i-ai library in executable_git was updated to use CURSOR_AGENT env var and cursor-agent process name, but test scripts still used the old CURSOR_AI/cursor signals—causing Cursor detection to silently regress.

Changes

  • test_env_only.sh:

    • Replace CURSOR_AI with CURSOR_AGENT in test cases
    • Fix function extraction to source ami_check_env and its dependencies from the bundled library
  • test_detection.sh:

    • Add CURSOR_AGENT env var detection to check_env_vars()
    • Change process tree pattern from cursor to cursor-agent
# Before
CURSOR_AI=1 check_env_vars  # ❌ No longer detected

# After  
CURSOR_AGENT=1 check_env_vars  # ✅ Detects cursor
Original prompt

This section details on the original issue you should resolve

<issue_title>Cursor detection no longer matches existing inputs</issue_title>
<issue_description>P1 Badge Cursor detection no longer matches existing inputs

The Cursor checks now only look for CURSOR_AGENT/cursor-agent, but the repo’s own fixtures still set CURSOR_AI and search for a cursor process (see test_env_only.sh lines 10–26 and test_detection.sh lines 92–94). Running the current tests or any environment that still uses the old CURSOR_AI flag will now produce no Cursor detection, so the updated library immediately regresses our validation for Cursor without updating the callers or tests to the new signal names.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in #40 (comment)
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Summary by cubic

Update Cursor detection in test scripts to use CURSOR_AGENT and cursor-agent, matching the library and preventing false positives. This resolves the regression and re-enables reliable Cursor validation.

Written for commit f4af68c. Summary will update automatically on new commits.

Copilot AI and others added 2 commits November 29, 2025 12:06
Co-authored-by: trieloff <39613+trieloff@users.noreply.github.com>
Co-authored-by: trieloff <39613+trieloff@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix cursor detection to match existing inputs Fix Cursor detection to use CURSOR_AGENT/cursor-agent signals Nov 29, 2025
Copilot AI requested a review from trieloff November 29, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cursor detection no longer matches existing inputs

2 participants