Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tokio support #109

Merged

Conversation

folkertdev
Copy link
Collaborator

The tokio-io crate has long been deprecated (last updated ~5 years ago). It's extremely incompatible with the ecosystem today, so effectively just dead weight.

An alternative is to use the real tokio with an extremely restricted feature set (mostly just the traits), but e.g. flate2, zstd and brotli don't do that.

I reused the older #89 but it needed some rebasing and missed a some uses of the tokio feature.

@alexcrichton alexcrichton merged commit 84d7188 into trifectatechfoundation:master Dec 3, 2024
9 checks passed
@alexcrichton
Copy link
Collaborator

Thanks!

#[cfg(feature = "tokio")]
impl<W: AsyncRead + AsyncWrite> AsyncRead for BzEncoder<W> {}

impl<W: Write> Drop for BzEncoder<W> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @folkertdev @alexcrichton, is there any reason to remove this?
I found that in version 0.5.0, dropping the BzEncoder no longer auto finishes it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#121 re-adds this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants