Don't return to parent after fork #886
Merged
+25
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a CI fix. See the commit message. |
|
Is it possible to write a regression test for this? |
|
If I recall correctly the original case where I found the panic is as follows:
On Linux PAM will ask the user to authenticate even when the user wants to run su to become itself. On FreeBSD PAM will allow su to be used without authentication when the target is the same as the calling user. I'm not sure how to configure Linux PAM to get the FreeBSD behavior in a test. |
bjorn3
force-pushed
the
no_fork_return
branch
2 times, most recently
from
2b2bb1b
to
c9b5a80
Compare
|
It's OK to make an issue for this, so we can track the project. :) |
bjorn3
force-pushed
the
no_fork_return
branch
3 times, most recently
from
644e1d3
to
6ff7332
Compare
bjorn3
force-pushed
the
no_fork_return
branch
2 times, most recently
from
f991c69
to
ba7d2db
Compare
squell
force-pushed
the
no_fork_return
branch
from
ba7d2db
to
e1811ec
Compare
bjorn3
force-pushed
the
no_fork_return
branch
from
e1811ec
to
24a3ea4
Compare
bjorn3
force-pushed
the
no_fork_return
branch
2 times, most recently
from
18329c1
to
475fc21
Compare
This can cause closed files to be closed again, which will panic and is a violation of IO safety.
This makes it clearer that exec_monitor can only return when there is an error.
bjorn3
force-pushed
the
no_fork_return
branch
from
475fc21
to
4209e46
Compare
squell
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can cause closed files to be closed again, which will panic and is a violation of IO safety.