Ktv/minor improvements #25
Conversation
…kes it possible to know where the error occurred. bumped app auth
| } | ||
| } | ||
|
|
||
| public func isKeyLocked() -> Bool { |
There was a problem hiding this comment.
Jeg ville bruge computer propperties her i stedet
| isKeyServiceError(.keyLocked) | ||
| } | ||
|
|
||
| public func isWrongPassword() -> Bool { |
There was a problem hiding this comment.
Jeg ville bruge computer propperties her i stedet
| isKeyServiceError(.badPassword) | ||
| } | ||
|
|
||
| public func isBiometricFailedError() -> Bool { |
There was a problem hiding this comment.
Jeg ville bruge computer propperties her i stedet
| /// | ||
| /// This might be useful for handling unexpected cases from the encryption part of the framework. | ||
| /// When the key service fails you don't want to do any drastic fallback, since the server might "just" be down or the user have no internet connection. You will be able to recover later on, from a key service error. | ||
| public func isKeyServiceError() -> Bool { |
There was a problem hiding this comment.
Jeg ville bruge computer propperties her i stedet
|
Hvad er tanken med breaking changes så? er det "bare" og bump major eller? :) |
|
Ah, så det ikke. Venligst ignorer så |
|
Er dette noget som skal merges, eller bør dette PR lukkes? :) |
|
@nharbo det var nogle ret "nice" forbedringer i forhold til fejlsøgning. jeg husker ikke lige om der var lidt oprydningn også. så jo det vil jeg mene, at det stadig er aktuelt. |
|
Skal vi så ikke få gjort noget ved det @ktvtrifork ? :D |
|
@nharbo Ah jeg forklare lige konceptet; computed properties bør kun være konstante ting (kørsels tid) , hvor ting der "kan" tage mere tid (ikke trivielle ting) bør være funktioner. på den måde er det i fx loops nemt og se om du gøre noget der er meget langsomt (eller forkert osv). Ud fra den observation giver det semi mening det er funktioner for det er ikke "trivielt". ellers vil jeg give ret at det læses nok bedre som properties fordi de lyder simple. |
based on some debugging related to nil auth state in an app: Thus Added the stacktrace so its possible to backtrack where it happens. (since its likely a user error).
Also minor maintenance (bump) + some cleaning of the errors file and missing tests.