Skip to content

fix: audiowaveform extension #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

ThibautCuchet
Copy link
Contributor

@ThibautCuchet ThibautCuchet commented Sep 20, 2024

Closes #1334

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Run pnpm exec trigger deploy --profile local --self-hosted in references/v3-catalog and wait for building


Changelog

  • Add a step to fix packages dependencies at the end of audioWaveform extension

Screenshots

[Screenshots]

💯

Summary by CodeRabbit

  • Bug Fixes
    • Added a command to resolve broken dependencies during the installation of the audio waveform package, improving the build process reliability.
    • Introduced a patch for the package "@trigger.dev/build" to enhance functionality related to the audiowaveform extension.

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 42f56ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@trigger.dev/build Patch
trigger.dev Patch
@trigger.dev/core Patch
@trigger.dev/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

A new command has been added to the Dockerfile commands array in the AudioWaveformExtension class within the audioWaveform.ts file. This command, RUN apt-get install -y --fix-broken, is aimed at resolving broken dependencies during the installation of the audiowaveform package. The change modifies the build process sequence, specifically placed after the installation of the .deb package and before the removal of the downloaded package files. Additionally, a patch file for the "@trigger.dev/build" package has been introduced.

Changes

File Change Summary
packages/build/src/extensions/audioWaveform.ts Added command RUN apt-get install -y --fix-broken to handle broken dependencies during package installation. Introduced a patch file for @trigger.dev/build.

Assessment against linked issues

Objective Addressed Explanation
Address the issue of audioWaveform extension breaking apt-get install for subsequent extensions (#1334)

Possibly related PRs

  • fix: audiowaveform extension #1335: This PR also modifies the audioWaveform.ts file, adding the same command RUN apt-get install -y --fix-broken to address broken dependencies during the Docker build process for the audioWaveform extension.

Poem

🐰 In the land of code where bugs do roam,
A fix was found to bring us home.
With apt-get now in harmony,
Dependencies dance in unity.
Hooray for builds, let’s cheer and play!
For smoother paths, hip-hip-hooray! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Sep 20, 2024

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1335
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1335
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1335
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1335

commit: 42f56ab

@ericallam ericallam merged commit 1f5bcc7 into triggerdotdev:main Sep 20, 2024
3 checks passed
@ThibautCuchet ThibautCuchet deleted the fix--audiowaveform branch September 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: audioWaveform extension breaks apt-get install for next extensions when building the docker image
2 participants