Skip to content

Puppeteer extension: set the PUPPETEER_EXECUTABLE_PATH env var #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

samejr
Copy link
Member

@samejr samejr commented Sep 24, 2024

With this change when launching puppeteer you don't need to set the executable path.

Summary by CodeRabbit

  • New Features
    • Introduced configuration for Puppeteer to customize the executable path, enhancing flexibility in deployment.
    • Added a new deploy property to the Puppeteer extension for improved environment variable management.

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 427af4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@trigger.dev/build Patch
trigger.dev Patch
@trigger.dev/core Patch
@trigger.dev/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

A new file has been added to specify a patch for the package "@trigger.dev/build", introducing a configuration for a Puppeteer extension. This configuration sets the PUPPETEER_EXECUTABLE_PATH environment variable, directing Puppeteer to the appropriate binary. Additionally, the PuppeteerExtension class has been modified to include a new deploy property that contains the environment variable configuration.

Changes

Files Change Summary
.changeset/real-bags-joke.md Introduced a patch file for the package "@trigger.dev/build" with Puppeteer configuration.
packages/build/src/extensions/puppeteer.ts Updated PuppeteerExtension class to add a deploy property with PUPPETEER_EXECUTABLE_PATH.

Possibly related PRs

  • Feat: Extension puppeteer #1323: This PR also focuses on enhancing the Puppeteer extension, indicating a direct connection in terms of functionality and class modifications.

Suggested reviewers

  • ericallam

Poem

In the code where rabbits hop,
A Puppeteer now takes a stop.
With paths set right, it leaps with glee,
To find the Chrome, as swift as can be!
Extensions grow, like carrots in sun,
Hopping along, we’ve just begun! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@matt-aitken matt-aitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collaborated with @samejr on this

@samejr samejr merged commit bff38dc into main Sep 24, 2024
7 of 8 checks passed
@samejr samejr deleted the puppeteer-extension-env-var branch September 24, 2024 12:25
Copy link

pkg-pr-new bot commented Sep 24, 2024

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1350
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1350
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1350
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1350

commit: 427af4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants