Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bun runtime by downgrading to 1.1.24 #1409

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Fix bun runtime by downgrading to 1.1.24 #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d7df4c
pin bun to 1.1.24 and use slim image
nicktrn Oct 14, 2024
7efa91a
add changeset
nicktrn Oct 14, 2024
39cb7d7
add warning about bun version to docs
nicktrn Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-paws-accept.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"trigger.dev": patch
---

Fix an IPC bug when using bun by pinning to an older version.
2 changes: 2 additions & 0 deletions docs/guides/frameworks/bun.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import Prerequisites from "/snippets/framework-prerequisites.mdx";
import CliRunTestStep from "/snippets/step-run-test.mdx";
import CliViewRunStep from "/snippets/step-view-run.mdx";

<Warning>A specific Bun version is currently required for the dev command to work. This is due to a [bug](https://github.com/oven-sh/bun/issues/13799) with IPC. Please use Bun version 1.1.24 or lower: `curl -fsSL https://bun.sh/install | bash -s -- bun-v1.1.24`</Warning>

We now have experimental support for Bun. This guide will show you have to setup Trigger.dev in your existing Bun project, test an example task, and view the run.

<Warn>
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-v3/src/deploy/buildImage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ async function generateBunContainerfile(options: GenerateContainerfileOptions) {
);

return `# syntax=docker/dockerfile:1
FROM imbios/bun-node:22-debian AS base
FROM imbios/bun-node:1.1.24-22-slim@sha256:9cfb7cd87529261c482fe17d8894c0986263f3a5ccf84ad65c00ec0e1ed539c6 AS base

${baseInstructions}

Expand Down
Loading