Skip to content

chore: remove unnecessary browser export condition #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

ericallam
Copy link
Member

@ericallam ericallam commented Nov 1, 2024

Closes #1454

Removes the “browser” export condition from @trigger.dev/sdk/v3 which didn’t export a bunch of stuff that’s needed on edge runtimes.

Summary by CodeRabbit

  • New Features

    • Simplified export logic for the @trigger.dev/sdk package, enhancing its usability across different environments.
  • Bug Fixes

    • Removed unnecessary browser export conditions, improving integration with react-hooks.
  • Chores

    • Updated package.json to streamline export configurations, focusing on core functionalities without browser-specific settings.

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 70d07b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@trigger.dev/sdk Patch
@trigger.dev/build Patch
@trigger.dev/core Patch
@trigger.dev/react-hooks Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch
trigger.dev Patch
@internal/redis-worker Patch
@internal/zod-worker Patch
@internal/testcontainers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Walkthrough

The changes in this pull request involve modifications to the @trigger.dev/sdk package, specifically the removal of browser-specific export conditions in the package.json file. This update simplifies the export logic by eliminating the browser entries from the exports field and the esmDialects section, allowing for a more streamlined integration with core functionalities and react-hooks. No alterations were made to the declarations of exported or public entities.

Changes

File Path Change Summary
.changeset/weak-comics-burn.md Removed browser export condition from @trigger.dev/sdk package.
packages/trigger-sdk/package.json Removed esmDialects section and browser entries from exports for root and ./v3 paths.

Assessment against linked issues

Objective Addressed Explanation
Export more from the browser export (1454) The removal of browser exports does not address the need for more exports.

Possibly related PRs

  • README updates #1408: The README updates include enhancements related to the @trigger.dev/sdk, which may provide context or usage information relevant to the changes made in the main PR regarding the package's export logic.

Poem

🐰 In the land of code where rabbits play,
Exports once tricky have found their way.
With browser checks gone, oh what a sight,
Simplified paths make our coding bright!
Hops of joy as we streamline our quest,
In the world of SDKs, we code with zest! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 58def05 and 70d07b2.

📒 Files selected for processing (2)
  • .changeset/weak-comics-burn.md (1 hunks)
  • packages/trigger-sdk/package.json (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/trigger-sdk/package.json
✅ Files skipped from review due to trivial changes (1)
  • .changeset/weak-comics-burn.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Nov 1, 2024

@trigger.dev/react-hooks

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1455

@trigger.dev/build

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1455

trigger.dev

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1455

@trigger.dev/sdk

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1455

@trigger.dev/core

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1455

commit: 70d07b2

@ericallam ericallam merged commit cc74cae into main Nov 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing export tasks from @trigger.dev/sdk/v3
1 participant