Deleting v2 dashboard/api #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 117 files out of 295 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
matt-aitken
changed the title
…-v2-eol # Conflicts: # apps/webapp/app/components/primitives/TextLink.tsx # apps/webapp/app/v3/marqs/v2.server.ts
# Conflicts: # apps/webapp/app/components/navigation/SideMenu.tsx # apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.events.$eventParam/route.tsx # apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.electric.$runParam/route.tsx # apps/webapp/app/services/worker.server.ts # apps/webapp/app/utils/pathBuilder.ts # apps/webapp/app/v3/marqs/v2.server.ts
samejr
approved these changes
Mar 7, 2025
ericallam
approved these changes
Mar 7, 2025
…-v2-eol # Conflicts: # apps/webapp/app/components/run/TriggerDetail.tsx # apps/webapp/app/components/runs/v3/RunIcon.tsx # apps/webapp/app/entry.server.tsx # apps/webapp/app/presenters/HttpEndpointPresenter.server.ts # apps/webapp/app/routes/api.v1.$endpointSlug.schedules.$id.registrations.ts # apps/webapp/app/routes/api.v1.$endpointSlug.sources.$id.ts # apps/webapp/app/routes/api.v1.$endpointSlug.triggers.$id.registrations.$key.ts # apps/webapp/app/routes/api.v1.$endpointSlug.triggers.$id.registrations.ts # apps/webapp/app/routes/api.v1.accounts.$accountId.connections.$clientSlug/route.ts # apps/webapp/app/routes/api.v1.endpointindex.$indexId.ts # apps/webapp/app/routes/api.v1.event-dispatchers.ephemeral.ts # apps/webapp/app/routes/api.v1.events.$eventId.ts # apps/webapp/app/routes/api.v1.events.bulk.ts # apps/webapp/app/routes/api.v1.events.ts # apps/webapp/app/routes/api.v1.http-endpoints.$httpEndpointId.env.$envType.$shortcode.ts # apps/webapp/app/routes/api.v1.jobs.$jobSlug.invoke.ts # apps/webapp/app/routes/api.v1.runs.$runId.logs/route.ts # apps/webapp/app/routes/api.v1.runs.$runId.statuses.$id/route.ts # apps/webapp/app/routes/api.v1.runs.$runId.statuses.ts # apps/webapp/app/routes/api.v1.runs.$runId.tasks.$id.complete/route.ts # apps/webapp/app/routes/api.v1.runs.$runId.tasks.$id.fail/route.ts # apps/webapp/app/routes/api.v1.runs.$runId.tasks/route.ts # apps/webapp/app/routes/api.v1.webhooks.$key.ts # apps/webapp/app/routes/api.v2.$endpointSlug.sources.$id.ts # apps/webapp/app/routes/api.v2.$endpointSlug.triggers.$id.registrations.$key.ts # apps/webapp/app/routes/api.v2.events.$eventId.ts # apps/webapp/app/routes/api.v2.runs.$runId.statuses.ts # apps/webapp/app/services/endpoints/indexEndpoint.server.ts # apps/webapp/app/services/endpoints/performEndpointIndexService.server.ts # apps/webapp/app/services/events/sqsEventConsumer.server.ts # apps/webapp/app/services/httpendpoint/HandleHttpEndpointService.server.ts # apps/webapp/app/services/triggers/registerWebhook.server.ts # apps/webapp/app/services/worker.server.ts # apps/webapp/remix.config.js # apps/webapp/tsconfig.json # packages/cli-v3/src/dev/backgroundWorker.ts # packages/core/package.json # references/hello-world/src/trigger/example.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger.dev v2 End of Life is January 31 2025. https://trigger.dev/blog/v2-end-of-life-announcement
This PR removes v2 code:
It also removes the
<NamedIcon />component which was a bad idea in hindsight. This was used across the dashboard.This PR does NOT remove any database tables, inc. from the schema. We need to be careful not to cause any downtime when we do this change.