-
-
Notifications
You must be signed in to change notification settings - Fork 708
Add configurable redis TTL on realtime streams #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThis update introduces two new integer configuration properties in the environment schema for real-time streaming: one for the maximum stream length and another for the TTL. The real-time stream service now uses these environment variables instead of hardcoded values, and it consolidates stream commands (xadd and expire) into a single Redis pipeline operation. Changes
Sequence Diagram(s)sequenceDiagram
participant S as Realtime Service
participant Env as Environment Config
participant R as Redis
S->>Env: Load REALTIME_STREAM_MAX_LENGTH & REALTIME_STREAM_TTL
S->>R: Execute xadd (with max length)
S->>R: Pipeline expire (using TTL)
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
47c2dd6
to
d9a5b98
Compare
Summary by CodeRabbit