Skip to content

Centering account pages and making them consistent #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented Mar 18, 2025

  • Removes maxWidths from the page contents so it fits the new container
  • Adds titles to make the pages consistent
  • When you update your org name, you stay on the same page with a toast confirmation

CleanShot 2025-03-18 at 12 47 35@2x
CleanShot 2025-03-18 at 12 47 47@2x
CleanShot 2025-03-18 at 12 48 07@2x

Summary by CodeRabbit

  • New Features

    • Updated organization settings with a new “Settings” header and refined labels (e.g., “Organization name” and “Icon”).
    • Enhanced the account profile page with a centered layout, a prominent “Profile” header, and full-width input fields.
    • Refreshed the team settings page with improved member list styling and updated invite button design.
  • Style

    • Adjusted button variants, spacing, and alignment across pages to boost visual consistency and clarity.

Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 9764e98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "proxy" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

Walkthrough

This pull request updates several route components in the Webapp. In the organizational settings routes, header components, UI layouts, and action redirect logic have been modified, including terminology changes from "logo" to "icon" and button variant updates. The team settings page sees adjustments to member count display, avatar sizing, and spacing. The account profile page now uses a newly imported centered container and header, with updated styling for profile photo and input fields.

Changes

File(s) Change Summary
apps/webapp/app/routes/_app.orgs.$organizationSlug.settings._index/route.tsx
apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx
Organizational Settings: Updated header imports (added Header3), refined action function redirect (now pointing to organizationSettingsPath), and terminology update from "logo" to "icon". Layout modifications include new header section, adjusted spacing in fieldsets, and button variant changes (from primary/small to secondary/small). Team page adjustments include updated member count styling, responsive avatar sizing, and margin and border tweaks.
apps/webapp/app/routes/account._index/route.tsx Account Profile: Revised layout using MainHorizontallyCenteredContainer and Header2, with corresponding updates to the profile photo styling (switched from fixed dimensions to a size-based class) and input groups (now full width). The submit button variant was also updated to secondary/small.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant UI as Organizational UI
    participant A as Action Function
    participant R as Router

    U->>UI: Submit rename organization request
    UI->>A: Send update request with new name
    A->>R: Process update and determine redirect destination
    R-->>A: Return success with organizationSettingsPath
    A-->>UI: Issue redirection to settings page
    UI->>U: Render updated organizational settings
Loading

Suggested reviewers

  • matt-aitken

Poem

I’m a little rabbit, hopping on the code,
Tweaking headers and buttons in a delightful mode.
With a skip and a jump, the routes now align,
Redirects and new layouts—everything is just fine!
Carrots and clean code, a merry sight to behold!
Happy hops in every commit, brave and bold!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b862b9 and 9764e98.

📒 Files selected for processing (3)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings._index/route.tsx (7 hunks)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx (3 hunks)
  • apps/webapp/app/routes/account._index/route.tsx (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (19)
apps/webapp/app/routes/account._index/route.tsx (6)

8-13: Good addition of the MainHorizontallyCenteredContainer component.

This import helps achieve the PR's goal of centering account pages and creating a consistent layout across the application.


19-19: Appropriate addition of Header2 component.

Adding this header component provides better visual hierarchy and consistent page structure across the application.


147-151: Good layout improvement with proper page header.

The addition of a dedicated header section with proper styling improves the visual structure of the page. The border and spacing provide clear visual separation between the header and content.


154-154: Modern CSS class usage for avatar sizing.

Replacing h-24 w-24 with size-24 is a more concise way to define equal width and height in Tailwind CSS.


157-157: Good addition of fullWidth prop to input groups.

Adding the fullWidth prop to these input groups ensures they take the full available width, improving the form layout consistency.

Also applies to: 168-168


192-192: Consistent button styling across the application.

Changing the button variant from "primary/small" to "secondary/small" maintains consistency with other forms in the application.

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx (6)

167-170: Improved member count display with better styling.

The member count is now displayed with proper styling using a <span> with dimmed text, which improves visual hierarchy and separation between the title and the count.


172-172: Improved list container width for better layout.

Removing the max-width constraint and using w-full allows the list to fit properly within the container, aligning with the PR goal of improving page layouts.


178-178: Modern CSS class usage for avatar sizing.

Replacing dimension-specific classes with size-10 is a more concise way to define equal width and height in Tailwind CSS.


200-201: Consistent spacing and border styling for pending invites section.

The margin and border styling changes create visual consistency with the rest of the page and align with the updated design system.


231-231: Proper spacing for the info panel.

Adding mt-4 provides appropriate spacing after the previous section, maintaining visual rhythm throughout the page.


242-242: Consistent button variant across the application.

Changing the button variant from "primary/small" to "secondary/small" maintains consistency with other forms in the application.

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings._index/route.tsx (7)

174-174: Improved user experience by keeping users on the same page after rename.

This change aligns with the PR objective of making the user remain on the same page after updating their organization name, providing a better user experience with the toast confirmation message.


229-229: Consistent terminology change from "logo" to "icon".

The success message now uses "icon" instead of "logo", ensuring terminology consistency throughout the application.


289-291: Good layout improvement with proper page header.

Adding a dedicated header section with appropriate styling improves the visual structure and creates consistency with other settings pages.


300-302: Improved form field group spacing and clearer label.

The vertical spacing adjustments and the label change from "Rename your organization" to "Organization name" provide better clarity and consistency.


316-316: Consistent button styling across the application.

Changing the button variant from "primary/small" to "secondary/small" maintains consistency with other forms in the application.


334-334: Improved danger zone form width.

Making the delete organization form full-width improves its prominence in the UI and creates consistency with other forms on the page.


391-395: Improved icon selection form layout.

The layout changes for the icon selection form, including the terminology change from "Logo" to "Icon" and the improved grid layout, create better visual alignment and spacing.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@samejr samejr merged commit ec1cec5 into main Mar 18, 2025
12 checks passed
@samejr samejr deleted the centering-account-pages branch March 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants