Fix snapshot status for short retry delays

[nicktrn]

The status is now EXECUTING as it should be. Previously PENDING_EXECUTING.

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the task execution status so that the system now properly indicates an "EXECUTING" state during retries following a failure.
• Tests
  • Updated automated tests to verify the revised status behavior, ensuring consistency with the improved execution tracking.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 99b0748

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes update the execution status within the RunAttemptSystem when an attempt fails. The status in the snapshot creation is now set to "EXECUTING" instead of "PENDING_EXECUTING". Corresponding test assertions in both the attempt failures and waitpoints tests have been updated to match this new status.

Changes

File(s)	Change Summary
internal-packages/run-engine/.../systems/runAttemptSystem.ts	Changed the snapshot’s executionStatus in the attemptFailed method from "PENDING_EXECUTING" to "EXECUTING".
internal-packages/run-engine/.../tests/attemptFailures.test.ts, internal-packages/run-engine/.../tests/waitpoints.test.ts	Updated test assertions to expect the execution status "EXECUTING" instead of "PENDING_EXECUTING".

Sequence Diagram(s)

sequenceDiagram
    participant RA as RunAttemptSystem
    participant SD as SnapshotData
    RA->>SD: Call attemptFailed()
    SD-->>RA: Return snapshot with executionStatus = "EXECUTING"

Loading

Possibly related PRs

• Fix v4 restore race condition #1870: Addresses handling of execution statuses in run attempt scenarios, aligning with the updated status in this PR.
• Fix: Prevent some attempt creation retries from causing system failures #1550: Focuses on modifications related to retrying attempts and setting execution status to "EXECUTING", similar to the changes here.

Suggested reviewers

• ericallam
• matt-aitken

Poem

I'm a rabbit coding away,
Hopping through logic both night and day.
From "PENDING" leaps a new state so bright,
"EXECUTING" now guides our flight.
Carrot dreams and code entwine,
Celebrating changes so fine!
🥕🐇 Happy hops and flawless lines!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f12141b and 99b0748.

📒 Files selected for processing (3)

• internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts (1 hunks)
• internal-packages/run-engine/src/engine/tests/attemptFailures.test.ts (1 hunks)
• internal-packages/run-engine/src/engine/tests/waitpoints.test.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

internal-packages/run-engine/src/engine/tests/attemptFailures.test.ts (4)

packages/core/src/v3/workers/taskExecutor.ts (1)

• result (1122-1169)

apps/webapp/app/v3/runEngine.server.ts (1)

• engine (9-9)

apps/webapp/app/v3/services/completeAttempt.server.ts (1)

• run (453-551)

internal-packages/testcontainers/src/index.ts (1)

• assertNonNullable (9-9)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (5)

internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts (1)

742-742: Status corrected from "PENDING_EXECUTING" to "EXECUTING" for short retry delays.

The change fixes the snapshot status during short retry delays to accurately represent that the run is still executing rather than pending execution. This aligns better with the system's execution model where retry scenarios with short delays continue execution without a pending state.

internal-packages/run-engine/src/engine/tests/attemptFailures.test.ts (2)

107-107: Test assertion updated to match new execution status.

Test assertion correctly updated to expect "EXECUTING" status instead of "PENDING_EXECUTING" following the change in RunAttemptSystem.

---

113-113: Test assertion updated to match new execution status.

Correctly adjusted the expected execution status in the validation check after retrieving the run execution data.

internal-packages/run-engine/src/engine/tests/waitpoints.test.ts (2)

242-242: Test assertion updated to match new execution status.

Test assertion correctly updated to expect "EXECUTING" status instead of "PENDING_EXECUTING" following the change in RunAttemptSystem.

---

248-248: Test assertion updated to match new execution status.

Correctly adjusted the expected execution status in the validation check after retrieving the run execution data.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.