Skip to content

Adds a new entry in the help and feedback modal to request more concurrency #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented Apr 17, 2025

  • Adds a new entry that submits to Slack as "Increase my concurrency"
  • New wording shown in the modal to explain the pricing and more info to provide
  • Tweaks the modal layout slightly

CleanShot 2025-04-17 at 14 45 33

Summary by CodeRabbit

  • New Features
    • Added a new "concurrency" feedback option with specific guidance and information for users requesting increased concurrency.
  • Improvements
    • Updated button text to "Increase limit…" for clarity.
    • Adjusted default feedback category to "concurrency" for relevant actions.
  • Bug Fixes
    • Improved conditional display of information panels and separators based on feedback type.

Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: 949fe1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 17, 2025

Walkthrough

This change introduces a new "concurrency" feedback type to the feedback system in the web application. The Feedback component is updated to display a specific informational panel when the "concurrency" type is selected, including an icon and guidance text. The feedback type labels are expanded to include this new type. Additionally, the default feedback type and button label are updated in one route to reflect the new "concurrency" option. Some import statements are cleaned up for better type safety and unused imports are removed.

Changes

File(s) Change Summary
apps/webapp/app/components/Feedback.tsx Added "concurrency" feedback type: imports ArrowUpCircleIcon, conditionally renders an InfoPanel for concurrency, and adjusts <hr> rendering.
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx Changed Feedback button label to "Increase limit…", set default feedback type to "concurrency".
apps/webapp/app/routes/resources.feedback.ts Added "concurrency" to feedbackTypeLabel, refactored imports to use type-only imports, and removed unused imports.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant FeedbackComponent

    User->>UI: Opens Feedback form
    UI->>FeedbackComponent: Render with default type "concurrency"
    FeedbackComponent-->>UI: Shows InfoPanel for concurrency (if selected)
    User->>FeedbackComponent: Submits feedback with type "concurrency"
Loading

Possibly related PRs

  • triggerdotdev/trigger.dev#1374: Adds a new concurrency feedback type and related UI elements, similar to this PR's introduction of the concurrency feedback type and InfoPanel.

Suggested reviewers

  • matt-aitken

Poem

In the meadow of code, a new path appears,
"Concurrency" whispers in bunny ears.
With icons and panels, the message is clear,
More bundles for queues—no need to fear!
Buttons now twinkle with an ellipsis delight,
Feedback hops forward, everything’s right.
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33e7b68 and 949fe1a.

📒 Files selected for processing (3)
  • apps/webapp/app/components/Feedback.tsx (3 hunks)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1 hunks)
  • apps/webapp/app/routes/resources.feedback.ts (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1)
apps/webapp/app/components/primitives/Buttons.tsx (1)
  • Button (291-324)
apps/webapp/app/components/Feedback.tsx (1)
apps/webapp/app/components/primitives/InfoPanel.tsx (1)
  • InfoPanel (30-68)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (7)
apps/webapp/app/routes/resources.feedback.ts (2)

2-3: Improved type safety with type modifiers

The import statements have been properly updated to use TypeScript's type modifier for imports that are only used as types. This is a good practice as it ensures these imports are removed during compilation, potentially reducing bundle size.


17-17: LGTM: New concurrency feedback option added

The new "concurrency" feedback type has been properly added to the feedbackTypeLabel object, following the existing pattern of the other feedback types.

apps/webapp/app/components/Feedback.tsx (3)

3-3: LGTM: Added ArrowUpCircleIcon import

The ArrowUpCircleIcon has been properly imported for use with the new concurrency feedback type.


67-69: LGTM: Updated conditional rendering for horizontal rule

The condition for rendering the horizontal rule has been properly updated to include the new "concurrency" type in the exclusion list, maintaining UI consistency with the other special feedback types.


102-114: LGTM: Well-implemented UI for concurrency feedback

The new InfoPanel for the "concurrency" feedback type follows the existing pattern established for other feedback types. The panel provides clear guidance about concurrency bundles, pricing, and what information users should provide.

The indigo color theming for the icon is consistent with the ArrowUpCircleIcon styling used elsewhere in the application.

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (2)

265-265: LGTM: Improved button label with ellipsis

Adding the ellipsis to "Increase limit…" properly indicates to users that clicking this button will open a dialog for more information or options, which aligns with UI best practices.


268-268: LGTM: Updated default feedback type

Changing the default feedback type from "help" to "concurrency" for this specific button ensures that users are directed to the appropriate feedback form with relevant guidance when they want to increase their concurrency limits.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ericallam ericallam merged commit 2aacf76 into main Apr 17, 2025
11 of 12 checks passed
@ericallam ericallam deleted the request-more-concurrency-modal branch April 17, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants