-
-
Notifications
You must be signed in to change notification settings - Fork 708
Docs v4 migration guide: Updates the run function param syntax + adds new run.list() example #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe upgrade documentation for version 4 has been revised to clarify lifecycle hook function signatures, update examples for the Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/upgrade-to-v4.mdx (2)
706-707
: Nit: Remove extra whitespace in therun
signature example
There's an unintended leading space beforepayload
in the code block comment. It should align with the other hooks and match the documented signature.
Apply this diff for consistency:- // The run function still uses separate parameters - run: async ( payload, { ctx }) => {}, + // The run function still uses separate parameters + run: async (payload, { ctx }) => {},
511-511
: Optional: Use consistent admonition for known issues
The line**ISSUE:** Runs not continuing after a child run(s) have completed.could be formatted using the existing
<Note>
or<Warning>
components for better consistency and visibility. For example:<Warning> Runs may not continue after completing child runs. We are tracking a fix for this issue. </Warning>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/upgrade-to-v4.mdx
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
docs/upgrade-to-v4.mdx (2)
723-723
: Correctly preservedrun
signature in extended hooks example
This snippet accurately shows thatrun
still takes separate parameters(payload, { ctx })
, consistent with the v4 signature change.
736-763
: BatchTrigger changes section—examples are clear and complete
The new code examples contrast the v3 direct access (batchHandle.runs
) with the v4 async list retrieval (await batchHandle.runs.list()
), which accurately reflects the API change. No updates needed here.
Summary by CodeRabbit
ctx
object, including removal of certain properties.batchTrigger
viaruns.list()
, with updated code examples.