Skip to content

[v4] When dequeuing if PENDING_EXECUTING don't fail the run #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

[v4] When dequeuing if PENDING_EXECUTING don't fail the run #2129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions internal-packages/run-engine/src/engine/systems/dequeueSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,20 @@ export class DequeueSystem {
const snapshot = await getLatestExecutionSnapshot(prisma, runId);

if (!isDequeueableExecutionStatus(snapshot.executionStatus)) {
// If it's pending executing it will be picked up by the stalled system if there's an issue
if (snapshot.executionStatus === "PENDING_EXECUTING") {
this.$.logger.error(
"RunEngine.dequeueFromMasterQueue(): Run is already PENDING_EXECUTING, removing from queue",
{
runId,
orgId,
}
);
// remove the run from the queue
await this.$.runQueue.acknowledgeMessage(orgId, runId);
return null;
}

//create a failed snapshot
await this.executionSnapshotSystem.createExecutionSnapshot(prisma, {
run: {
Expand Down