Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of OAuth2AuthenticationFailedException #193

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Mar 31, 2020

Just a consistency thing.

@HypeMC HypeMC force-pushed the fix-class-casing branch from 95c01da to 9ec7875 Compare March 31, 2020 15:49
@HypeMC HypeMC requested a review from X-Coder264 March 31, 2020 15:50
@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

Merging #193 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage     92.05%   92.05%           
  Complexity      381      381           
=========================================
  Files            56       56           
  Lines          1272     1272           
=========================================
  Hits           1171     1171           
  Misses          101      101           
Impacted Files Coverage Δ Complexity Δ
.../Exception/OAuth2AuthenticationFailedException.php 100.00% <ø> (ø) 1.00 <0.00> (?)
...entListener/ConvertExceptionToResponseListener.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
Security/Firewall/OAuth2Listener.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40fd51...9ec7875. Read the comment docs.

Copy link
Collaborator

@X-Coder264 X-Coder264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for consistency sake even though it is technically a breaking change 😄

@X-Coder264 X-Coder264 merged commit 99101c4 into master Apr 8, 2020
@X-Coder264 X-Coder264 deleted the fix-class-casing branch April 8, 2020 08:20
@HypeMC
Copy link
Contributor Author

HypeMC commented Apr 8, 2020

@X-Coder264 Target branch is master, so breaking changes are ok.

@X-Coder264
Copy link
Collaborator

@HypeMC I know, I wouldn't have merged a breaking change into 2.x 😄

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (b40fd51) to head (9ec7875).
Report is 112 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage     92.05%   92.05%           
  Complexity      381      381           
=========================================
  Files            56       56           
  Lines          1272     1272           
=========================================
  Hits           1171     1171           
  Misses          101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants