Add cleanup for revoked tokens with appropriate indexes #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Coder264
requested changes
Oct 14, 2020
HypeMC
reviewed
Oct 14, 2020
HypeMC
reviewed
Oct 14, 2020
HypeMC
suggested changes
Oct 14, 2020
HypeMC
suggested changes
Oct 19, 2020
X-Coder264
reviewed
Oct 19, 2020
X-Coder264
reviewed
Oct 19, 2020
X-Coder264
requested changes
Oct 21, 2020
Codecov Report
@@ Coverage Diff @@
## v3.x #234 +/- ##
============================================
+ Coverage 92.65% 93.09% +0.44%
- Complexity 395 415 +20
============================================
Files 59 60 +1
Lines 1415 1507 +92
============================================
+ Hits 1311 1403 +92
Misses 104 104
Continue to review full report at Codecov.
|
HypeMC
reviewed
Oct 22, 2020
HypeMC
approved these changes
Oct 23, 2020
X-Coder264
approved these changes
Oct 23, 2020
X-Coder264
requested changes
Oct 23, 2020
There was a problem hiding this comment.
@franjo-zadelj-trikoder The pipeline is broken:
dev/bin/php-test composer test -- --colors=always --coverage-clover=coverage.xml --debug
> phpunit '--colors=always' '--coverage-clover=coverage.xml' '--debug'
PHP Parse error: syntax error, unexpected ')' in /app/src/Tests/Acceptance/ClearRevokedTokensCommandTest.php on line 187
Parse error: syntax error, unexpected ')' in /app/src/Tests/Acceptance/ClearRevokedTokensCommandTest.php on line 187
Script phpunit handling the test event returned with error code 255
The command "dev/bin/php-test composer test -- --colors=always --coverage-clover=coverage.xml --debug" exited with 255.
X-Coder264
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for revoked tokens + indexes