Decoupled models from managers #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @spideyfusion could you please consider this merge? It is fully backward compatible and may solve others issue as well. |
|
Friendly ping. Is there anything blocking this PR? |
|
@MichaelKubovic Unfortunately this is a breaking change for people who already implemented the interfaces on which you've widened the type from the concrete class to the interface so we'll merge this into
http://sandbox.onlinephpfunctions.com/code/e71ddc05989b9aac2654c19bdab5863adc9362ad |
HypeMC
force-pushed
the
managers-decouple
branch
from
ec25c63 to
b011094
Compare
|
@denisvanmorgan Thank you for your contribution. |
|
@HypeMC happy to contribute, thank you for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this problem recently where I needed to override doctrine mappings with my custom mappings and models as well thus override some manager classes to use my models. While doing this I realized that manager interfaces are dependant on concrete classes rather than abstractions. This change should bring more flexibility and freedom when overriding default managers with custom models.