Merge Pull Request #9860 from trilinos/Trilinos/tpetra_9856

Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Tpetra:  reproducer for #9856
PR Author: kddevin

packages/tpetra/core/test/MultiVector/Bug9856.cpp

@@ -0,0 +1,303 @@
+/*
+// @HEADER
+// ***********************************************************************
+//
+//          Tpetra: Templated Linear Algebra Services Package
+//                 Copyright (2008) Sandia Corporation
+//
+// Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,
+// the U.S. Government retains certain rights in this software.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// 1. Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+//
+// 2. Redistributions in binary form must reproduce the above copyright
+// notice, this list of conditions and the following disclaimer in the
+// documentation and/or other materials provided with the distribution.
+//
+// 3. Neither the name of the Corporation nor the names of the
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY SANDIA CORPORATION "AS IS" AND ANY
+// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL SANDIA CORPORATION OR THE
+// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+// LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+// NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+//
+// ************************************************************************
+// @HEADER
+*/
+
+// Computes norms in both host and device space to exercise calls 
+// to KokkosBlas in both cases.
+
+#include "Tpetra_Core.hpp"
+#include "Tpetra_MultiVector.hpp"
+#include "Teuchos_ArrayView.hpp"
+#include "Teuchos_RCP.hpp"
+#include "KokkosBlas.hpp"
+
+#include "Teuchos_UnitTestHarness.hpp"
+#include "TpetraCore_ETIHelperMacros.h"
+
+namespace {
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, HostNorm180, Scalar,LO,GO,Node)
+{
+  // Compute the norm on the host with 180 vectors
+
+  auto comm = Tpetra::getDefaultComm();
+
+  using map_t = Tpetra::Map<LO,GO,Node>;
+  using mv_t = Tpetra::MultiVector<Scalar,LO,GO,Node>;
+
+  const size_t nGlobalEntries = 100;  
+  const size_t nVecs = 180;
+
+  Teuchos::RCP<const map_t> map = rcp(new map_t(nGlobalEntries, 0, comm));
+  mv_t mv(map, nVecs);
+  mv.putScalar(3.14);
+
+  // grab host view to ensure device is not most up-to-date
+  {
+    auto hostview = mv.getLocalViewHost(Tpetra::Access::ReadWrite);
+  }
+
+  std::vector<Scalar> norm(nVecs);
+  Teuchos::ArrayView<Scalar> normView(norm);
+
+  TEST_NOTHROW( mv.norm2(normView) );
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, HostNorm181, Scalar,LO,GO,Node)
+{
+  // Compute the norm on the host with 181 vectors
+
+  auto comm = Tpetra::getDefaultComm();
+
+  using map_t = Tpetra::Map<LO,GO,Node>;
+  using mv_t = Tpetra::MultiVector<Scalar,LO,GO,Node>;
+
+  const size_t nGlobalEntries = 100;  
+  const size_t nVecs = 181;
+
+  Teuchos::RCP<const map_t> map = rcp(new map_t(nGlobalEntries, 0, comm));
+  mv_t mv(map, nVecs);
+  mv.putScalar(3.14);
+
+  // grab host view to ensure device is not most up-to-date
+  {
+    auto hostview = mv.getLocalViewHost(Tpetra::Access::ReadWrite);
+  }
+
+  std::vector<Scalar> norm(nVecs);
+  Teuchos::ArrayView<Scalar> normView(norm);
+
+  TEST_NOTHROW( mv.norm2(normView) );
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, DeviceNorm180, Scalar,LO,GO,Node)
+{
+  // Compute the norm on the device with 180 vectors
+
+  auto comm = Tpetra::getDefaultComm();
+
+  using map_t = Tpetra::Map<LO,GO,Node>;
+  using mv_t = Tpetra::MultiVector<Scalar,LO,GO,Node>;
+
+  const size_t nGlobalEntries = 100;  
+  const size_t nVecs = 180;
+
+  Teuchos::RCP<const map_t> map = rcp(new map_t(nGlobalEntries, 0, comm));
+  mv_t mv(map, nVecs);
+  mv.putScalar(3.14);
+
+  // grab device view to ensure device is most up-to-date
+  {
+    auto deviceview = mv.getLocalViewDevice(Tpetra::Access::ReadWrite);
+  }
+
+  std::vector<Scalar> norm(nVecs);
+  Teuchos::ArrayView<Scalar> normView(norm);
+
+  TEST_NOTHROW( mv.norm2(normView));
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, DeviceNorm181, Scalar,LO,GO,Node)
+{
+  // This test reproduces the issue in issue #9856
+  // Compute the norm on the device with 181 vectors
+
+  auto comm = Tpetra::getDefaultComm();
+
+  using map_t = Tpetra::Map<LO,GO,Node>;
+  using mv_t = Tpetra::MultiVector<Scalar,LO,GO,Node>;
+
+  const size_t nGlobalEntries = 100;  
+  const size_t nVecs = 181;
+
+  Teuchos::RCP<const map_t> map = rcp(new map_t(nGlobalEntries, 0, comm));
+  mv_t mv(map, nVecs);
+  mv.putScalar(3.14);
+
+  // grab device view to ensure device is most up-to-date
+  {
+    auto deviceview = mv.getLocalViewDevice(Tpetra::Access::ReadWrite);
+  }
+
+  std::vector<Scalar> norm(nVecs);
+  Teuchos::ArrayView<Scalar> normView(norm);
+
+  TEST_NOTHROW( mv.norm2(normView) );
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, KokkosDeviceNorm180, Scalar,LO,GO,Node)
+{
+  // Compute the norm on the device with 180 vectors
+  // Kokkos only version
+
+  const size_t nGlobalEntries = 100;  
+  const size_t nVecs = 180;
+
+  using IST = typename Kokkos::Details::ArithTraits<Scalar>::val_type;
+
+  Kokkos::View<IST **, Kokkos::LayoutLeft, typename Node::device_type> 
+          mv("mv", nGlobalEntries, nVecs);
+  Kokkos::deep_copy(mv, 3.14);
+
+  using MST = typename Kokkos::Details::ArithTraits<Scalar>::mag_type;
+  std::vector<MST> norm(nVecs);
+  Kokkos::View<MST*, Kokkos::HostSpace> normView(&norm[0], nVecs);
+
+  TEST_NOTHROW( KokkosBlas::nrm2_squared(normView, mv));
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, KokkosDeviceNorm181, Scalar,LO,GO,Node)
+{
+  // This test reproduces the issue in issue #9856
+  // Compute the norm on the device with 181 vectors
+  // Kokkos only version
+
+  const size_t nGlobalEntries = 100;  
+  const size_t nVecs = 181;
+
+  using IST = typename Kokkos::Details::ArithTraits<Scalar>::val_type;
+
+  Kokkos::View<IST **, Kokkos::LayoutLeft, typename Node::device_type> 
+          mv("mv", nGlobalEntries, nVecs);
+  Kokkos::deep_copy(mv, 3.14);
+
+  using MST = typename Kokkos::Details::ArithTraits<Scalar>::mag_type;
+  std::vector<MST> norm(nVecs);
+  Kokkos::View<MST*, Kokkos::HostSpace> normView(&norm[0], nVecs);
+
+  TEST_NOTHROW( KokkosBlas::nrm2_squared(normView, mv));
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, LongDeviceNorm180, Scalar,LO,GO,Node)
+{
+  // Compute the norm on the device because the vector is long -- 180 vectors
+
+  auto comm = Tpetra::getDefaultComm();
+
+  using map_t = Tpetra::Map<LO,GO,Node>;
+  using mv_t = Tpetra::MultiVector<Scalar,LO,GO,Node>;
+
+  const size_t threshold = 
+               Tpetra::Details::Behavior::multivectorKernelLocationThreshold();
+  const size_t nGlobalEntries = comm->getSize() * 1.1 * threshold;
+  const size_t nVecs = 180;
+
+  Teuchos::RCP<const map_t> map = rcp(new map_t(nGlobalEntries, 0, comm));
+  mv_t mv(map, nVecs);
+  mv.putScalar(3.14);
+
+  // grab host view to ensure device is not most up-to-date;
+  // norm should run on device anyway because its length warrants a copy
+  {
+    auto hostview = mv.getLocalViewHost(Tpetra::Access::ReadWrite);
+  }
+
+  std::vector<Scalar> norm(nVecs);
+  Teuchos::ArrayView<Scalar> normView(norm);
+
+  TEST_NOTHROW( mv.norm2(normView) );
+}
+
+//////////////////////////////////////////////////////////////////////////////
+TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Bug9856, LongDeviceNorm181, Scalar,LO,GO,Node)
+{
+  // Compute the norm on the device because the vector is long -- 181 vectors
+
+  auto comm = Tpetra::getDefaultComm();
+
+  using map_t = Tpetra::Map<LO,GO,Node>;
+  using mv_t = Tpetra::MultiVector<Scalar,LO,GO,Node>;
+
+  const size_t threshold = 
+               Tpetra::Details::Behavior::multivectorKernelLocationThreshold();
+  const size_t nGlobalEntries = comm->getSize() * 1.1 * threshold;
+  const size_t nVecs = 181;
+
+  Teuchos::RCP<const map_t> map = rcp(new map_t(nGlobalEntries, 0, comm));
+  mv_t mv(map, nVecs);
+  mv.putScalar(3.14);
+
+  // grab host view to ensure device is not most up-to-date;
+  // norm should run on device anyway because its length warrants a copy
+  {
+    auto hostview = mv.getLocalViewHost(Tpetra::Access::ReadWrite);
+  }
+
+  std::vector<Scalar> norm(nVecs);
+  Teuchos::ArrayView<Scalar> normView(norm);
+
+  TEST_NOTHROW( mv.norm2(normView) );
+}
+
+#define UNIT_TEST_GROUP( SCALAR, LO, GO, NODE ) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, KokkosDeviceNorm180, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, KokkosDeviceNorm181, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, DeviceNorm180, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, DeviceNorm181, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, HostNorm180, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, HostNorm181, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, LongDeviceNorm180, SCALAR, LO, GO, NODE) \
+  TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Bug9856, LongDeviceNorm181, SCALAR, LO, GO, NODE) 
+
+  TPETRA_ETI_MANGLING_TYPEDEFS()
+
+  TPETRA_INSTANTIATE_TESTMV( UNIT_TEST_GROUP )
+
+} // namespace (anonymous)
+
+int main (int argc, char* argv[])
+{
+  // Initialize MPI (if enabled) before initializing Kokkos.  This
+  // lets MPI control things like pinning processes to sockets.
+  Teuchos::GlobalMPISession mpiSession (&argc, &argv);
+  Kokkos::initialize (argc, argv);
+  const int errCode =
+    Teuchos::UnitTestRepository::runUnitTestsFromMain (argc, argv);
+  Kokkos::finalize ();
+  return errCode;
+}
+

packages/tpetra/core/test/MultiVector/CMakeLists.txt

@@ -8,6 +8,15 @@ TRIBITS_ADD_EXECUTABLE_AND_TEST(
   ${MAXNP}
   )
 
+TRIBITS_ADD_EXECUTABLE_AND_TEST(
+  Bug9856
+  SOURCES
+    Bug9856
+  COMM serial mpi
+  NUM_MPI_PROCS 1
+  STANDARD_PASS_OUTPUT
+  )
+
 TRIBITS_ADD_EXECUTABLE_AND_TEST(
   Bug9583
   SOURCES