Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra::Vector::normWeighted emits a deprecated warning #104

Closed
mhoemmen opened this issue Jan 27, 2016 · 1 comment
Closed

Tpetra::Vector::normWeighted emits a deprecated warning #104

mhoemmen opened this issue Jan 27, 2016 · 1 comment
Labels
pkg: Tpetra

Comments

@mhoemmen
Copy link
Contributor

@trilinos/tpetra

Tpetra::Vector::normWeighted is deprecated. There's nothing wrong with deprecation. However, the method calls its parent class' method MultiVector::normWeighted, which is also deprecated. Even though nothing calls Vector::normWeighted any more, some compilers still emit a deprecated warning when building it, because it calls a deprecated method. This breaks builds that turn on warnings as errors.
mhoemmen pushed a commit that referenced this issue Jan 27, 2016
Tpetra::Vector: Fix deprecated warning (Issue #104)
9f19975 
@trilinos/tpetra Vector::normWeighted is deprecated.  It calls its
parent class' method MultiVector::normWeighted, which is also
deprecated.  Even though nothing calls Vector::normWeighted any more,
some compilers still emit a deprecated warning when building it, because
it calls a deprecated method.  This breaks builds that turn on warnings
as errors, and also adds useless noise to the build output.

This commit reimplements Vector::normWeighted so that it doesn't call
MultiVector::normWeighted.  This should fix Issue #104.

Build/Test Cases Summary
Enabled Packages: TpetraCore
Disabled Packages: FEI,STK,PyTrilinos,NOX,Teko,Piro
0) MPI_DEBUG => Test case MPI_DEBUG was not run! => Does not affect push readiness! (-1.00 min)
1) SERIAL_RELEASE => Test case SERIAL_RELEASE was not run! => Does not affect push readiness! (-1.00 min)
2) MPI_DEBUG_COMPLEX => passed: passed=85,notpassed=0 (7.06 min)
3) SERIAL_RELEASE => passed: passed=65,notpassed=0 (9.08 min)
@mhoemmen
Copy link
Contributor Author

I don't see this build warning on the Dashboard any more, so I'm closing the issue.

@dridzal dridzal mentioned this issue Jun 24, 2016
Closed
@jgfouca jgfouca mentioned this issue Jul 6, 2016
Merged
This was referenced Oct 29, 2021
Closed
Closed
Closed
@trilinos-autotester trilinos-autotester mentioned this issue Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Tpetra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhoemmen