Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elevate all packages and SE packages used by ATDM APPs to Primary Tested #2597

Closed
bartlettroscoe opened this issue Apr 19, 2018 · 6 comments
Closed

Elevate all packages and SE packages used by ATDM APPs to Primary Tested #2597

bartlettroscoe opened this issue Apr 19, 2018 · 6 comments
Assignees
@bartlettroscoe
Labels
ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. Framework tasks Framework tasks (used internally by Framework team) MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: enhancement Issue is an enhancement, not a bug

Comments

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Apr 19, 2018 •
edited
Loading

CC: @trilinos/framework, @fryeguy52

Blocked By: #4219, #4272

Description:

Currently, it seems that some of the subpackages used by the ATDM EMPIRE APP are labeled Secondary Tested (ST). Since ST is enabled by default with Trilinos in the EMPIRE Trilinos configuration, this makes sense that that would have happened. However, by definition, anything being used by ATDM APPs should be treated as Primary Tested (see here).

Therefore, this story is to identify which Trilinos subpackages are really being used by ATDM that are currently categorized as ST and elevate them to PT.
@bartlettroscoe bartlettroscoe added type: enhancement Issue is an enhancement, not a bug client: ATDM Any issue primarily impacting the ATDM project labels Apr 19, 2018
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Apr 19, 2018
@bartlettroscoe
Explicitly set default Trilinos_ENABLE_SECONDARY_TESTED_CODE=ON (TRIL…
b464f02 
…-171)

This does not change behavior because this is the Trilinos default, but this
just makes it explicit that ATMD builds of Trilinos actually do enable
Secondary Tested code.  This does not really impact the configuration of
Trilinos for EMPIRE but it does impact what subpackages get enabled for
SEACAS, for example.

NOTE: This should be set to OFF once trilinos#2597 is complete.
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Apr 20, 2018
@bartlettroscoe
Set DEFAULT values for project level cache vars (trilinos#2464)
6b4d0a3 
This allows the defaults to be set through SET( ... CACHE ...) statements in
files read in through Trilinos_CONFIGURE_OPTIONS_FILE.

This shows one big advantage of using the built-in cmake -C option for reading
in *.cmake files.  It ensures that any defaults set there are set there.

This will be used to allow the ATDM configuration of Trilinos to set the
default Trilinos_ENABLE_SECONDARY_TESTED_CODE=OFF after trilinos#2597 is complete.
@mhoemmen
Copy link
Contributor

@micahahoward @prwolfe

@bartlettroscoe
Copy link
Member Author

I am going to wait to work on this until after we get that ATDM Trilinos builds updated to support SPARC (see TRIL-212).

@mhoemmen
Copy link
Contributor

mhoemmen commented Aug 1, 2018

@bartlettroscoe getting stuff done :D

@bartlettroscoe bartlettroscoe added the ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams label Oct 26, 2018
@bartlettroscoe bartlettroscoe added the PA: Framework Issues that fall under the Trilinos Framework Product Area label Dec 7, 2018
@bartlettroscoe bartlettroscoe mentioned this issue Jan 19, 2019
Closed
@bartlettroscoe
Copy link
Member Author

FYI: First specific enable needed is given in #4219.

@bartlettroscoe bartlettroscoe self-assigned this Jan 25, 2019
@bartlettroscoe bartlettroscoe mentioned this issue Jan 26, 2019
Closed
@bartlettroscoe bartlettroscoe added the Framework tasks Framework tasks (used internally by Framework team) label Jan 26, 2019
@bartlettroscoe bartlettroscoe mentioned this issue Mar 29, 2019
Merged
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jun 5, 2021
@github-actions
Copy link

github-actions bot commented Jul 7, 2021

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Jul 7, 2021
@github-actions github-actions bot closed this as completed Jul 7, 2021
@trilinos-autotester trilinos-autotester mentioned this issue Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlettroscoe bartlettroscoe

Labels
ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. Framework tasks Framework tasks (used internally by Framework team) MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoemmen @bartlettroscoe