-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: Increase the minimum CMake version requirement #8401
Comments
I pinged @balay for xSDK input. xSDK already depends on a minimum of 3.14. The four specific platforms quoted used versions ranging from 3.17.4 to 3.18.2. |
I updated the table in the issue to reflect the versions @bartlettroscoe posted in our meeting chat. |
@jwillenbring do you have any information on the systems I didn't get data for? Are there any systems we're missing? |
@william76, FYI, I don't think anyone actually builds on production ATS-2 machine 'sierra' or the production ATS-1 machine 'trinity'. Instead, they build on the unclassified clones 'vortex' and 'mutrino', respectively, and copy over the libraries and executables. Therefore, I don't think it matters what version of CMake is actually installed on the production machines, only the unclassified SNL support clones for these. I will post the CMake versions for the TLCC2 and CTS-1 machines. |
Those modules are not used anymore so this should be removed from the table. |
@william76, below are most of the important systems at SNL that I know about. Looking over that you can see that everyone of those systems offers CMake 3.17.1 or newer. Also note that it is a single-line command to install CMake from source on every system I have ever tried. See: My vote is to go with making CMake 3.17.1 the minimum required version for Trilinos and TriBITS. That is also a version directly supported by the SEMS RHEL7 modules. Any objections? CEE RHEL7 (i.e. all of the 'ews...', 'ceerws...', 'ascic...' and 'ascicgpu...' machines including where the Trilinos PR builds run)
TLCC-2 (e.g. 'chama', 'skybridge')
CTS-1 (e.g. 'eclipse')
ATS-1 (e.g. 'mutrino', 'trinity')
ATS-2 (e.g. 'vortex', 'sierra')
Vanguard 1 (e.g. 'stria', 'astra')
Testbed 'ride' and 'white' (where the Trilinos CUDA PR builds currently run)
But note that also exists:
Testbed 'weaver'
|
Note the now-closed duplicate issue #6752 Also, note that the current plan described in TRILINOS-104 is to upgrade the minimum version to CMake 3.17.1 on Jan 21, 2021! This will open the door for more simplifications of TriBITS. |
It looks like the systems have a 3.17.x or newer CMake available... @jwillenbring lets chat on this in Monday's standup. |
The Trilinos Product Lead team agreed that 3.17 should be the new minimum CMake version. The timeline for this change is by January 31st. The Framework team can begin upgrading build to use 3.17 or newer now, and on January 31st, we should increase the minimum required version. |
FYI: We discussed this topic and the topic of dropping support for Makefile.export.* files at the Trilinos Product Leaders Meeting today. The action items that came out of that were:
This issue of dropping support for Makefile.export.* files really needs to be addressed in a new GitHub issue, not this issue (which is just about upgrading the minimum required version of CMake). |
FYI: See #8498 |
Just so you guys know, Kokkos will now transition to 3.17.1 as the minimum as discussed here. The next release into Trilinos will be after the proposed Jan 31st cutoff date. |
I have install the newest cmake and the newest version of ninja on white/ride/weaver so you should be able to:
|
I believe this is done as originally intended. If not, please reopen. The last remaining clean up bits I know of are being tracked separately. |
Related to:
|
…ilinos#8401) This brings in an updated version of TriBITS that required CMake 3.17+. This should not change the behavior of TriBITS for Trilinos. Related: TriBITSPub/TriBITS#299, TriBITSPub/TriBITS#360
…17-min Automatically Merged using Trilinos Pull Request AutoTester PR Title: Pull in TriBITS that requires CMake 3.17 and other TriBITS changes (#8401) PR Author: bartlettroscoe
Enhancement
There was a discussion today in the developers' meeting about updating the minimum-required version of CMake to something newer than 3.10.0. I think the general consensus was that we'd like to update this to the most recent version of CMake that's supported on platforms we care about, noting that anything over 3.13.x is a pretty big step and 3.14.x or newer would be ideal.
CMake Availability
Let's fill this chart in so we can get an idea of what platforms we care about:
This is related to #8387 and #8392 which I'm using to identify the PR builds that fail when using CMake 3.10.x.
ATTN: @trilinos/framework @ccober6 @crtrott @kddevin @bartlettroscoe
I just tagged folks who spoke up during the meeting today when we were speaking about this, feel free to unfollow this issue if you're not interested or tag others who I may have forgotten to @mention
Tasks
The text was updated successfully, but these errors were encountered: