Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build stats fails for PRs that don't build anything #9314

Closed
cgcgcg opened this issue Jun 19, 2021 · 3 comments
Closed

Build stats fails for PRs that don't build anything #9314

cgcgcg opened this issue Jun 19, 2021 · 3 comments
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests

Comments

@cgcgcg
Copy link
Contributor

cgcgcg commented Jun 19, 2021

Bug Report

@bartlettroscoe @jjellio

Description

The build stats script seems to fail for PR builds that don't compile anything:
https://testing.sandia.gov/cdash/viewTest.php?onlyfailed&buildid=9376784
@cgcgcg cgcgcg added the type: bug The primary issue is a bug in Trilinos code or tests label Jun 19, 2021
@bartlettroscoe
Copy link
Member

@cgcgcg, sorry about that. I will fix that ASAP and submit a PR.

@bartlettroscoe bartlettroscoe added the PA: Framework Issues that fall under the Trilinos Framework Product Area label Jun 19, 2021
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Jun 19, 2021
@bartlettroscoe
Gracefully exist with 0 when build_stats.csv file is empty (trilinos#…
0c287d6 
…9314)
@bartlettroscoe bartlettroscoe mentioned this issue Jun 19, 2021
Merged
@bartlettroscoe
Copy link
Member

@cgcgcg, the fix in in PR #9315. Can you please approve that PR so it can merge once testing is complete?

trilinos-autotester added a commit that referenced this issue Jun 19, 2021
@trilinos-autotester
Merge Pull Request #9315 from bartlettroscoe/Trilinos/9314-no-build-s…
e9a313c 
…tats

Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Gracefully exist with 0 when build_stats.csv file is empty (#9314)
PR Author: bartlettroscoe
@cgcgcg
Copy link
Contributor Author

cgcgcg commented Jun 20, 2021

Thanks for the fix!

@cgcgcg cgcgcg closed this as completed Jun 20, 2021
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 20, 2021
Merge 'trilinos/Trilinos:develop' (a2ef54a) into 'tcad-charon/Trilino…
4edf99d 
…s:develop' (19b4402).

* trilinos-develop:
  Gracefully exist with 0 when build_stats.csv file is empty (trilinos#9314)
  zoltan2:  fix memory leak when sizeof(SCOTCH_Num) == sizeof(lno_t) trilinos#9312
  Xpetra/MueLu testing: change proxy settings
  MueLu adapters: Skip unneeded initialization
  Ifpack2 Chebyshev: Avoid MV initialization
  Tpetra norms: Avoid allocation (intracomm) or avoid initialization (intercomm)
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 20, 2021
Merge 'trilinos/Trilinos:develop' (a2ef54a) into 'tcad-charon/Trilino…
c0cfee0 
…s:develop' (19b4402).

* trilinos-develop:
  Gracefully exist with 0 when build_stats.csv file is empty (trilinos#9314)
  zoltan2:  fix memory leak when sizeof(SCOTCH_Num) == sizeof(lno_t) trilinos#9312
  Xpetra/MueLu testing: change proxy settings
  MueLu adapters: Skip unneeded initialization
  Ifpack2 Chebyshev: Avoid MV initialization
  Tpetra norms: Avoid allocation (intracomm) or avoid initialization (intercomm)
seamill pushed a commit to seamill/Trilinos that referenced this issue Jul 28, 2021
Merge 'trilinos/Trilinos:develop' (a2ef54a) into 'EM-Plasma/Trilinos:…
bd62343 
…develop' (c0d311f).

* trilinos/develop:
  Gracefully exist with 0 when build_stats.csv file is empty (trilinos#9314)
  Xpetra/MueLu testing: change proxy settings
  MueLu adapters: Skip unneeded initialization
  Ifpack2 Chebyshev: Avoid MV initialization
  Tpetra norms: Avoid allocation (intracomm) or avoid initialization (intercomm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartlettroscoe @cgcgcg