Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ROCBLAS and ROCSPARSE Dependencies for Kernels package #11750

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Added ROCBLAS and ROCSPARSE Dependencies for Kernels package #11750

merged 2 commits into from
Mar 30, 2023
+129 −1

Conversation

mperrinel
Copy link
Contributor

@mperrinel mperrinel commented Mar 30, 2023 •
edited
Loading

@trilinos/kokkos-kernels

Motivation

This PR aims to add rocblas and rocsparse as some tpls for Trilinos.
That will permit to drive the corresponding kokkos-kernel options directly from Trilinos.

#11359
#10640

@mperrinel mperrinel marked this pull request as draft March 30, 2023 11:31
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@mperrinel mperrinel changed the title Added ROCBLAS and ROCSPARSE Dependendies for Kernels package Added ROCBLAS and ROCSPARSE Dependencies for Kernels package Mar 30, 2023
@lucbv lucbv requested a review from bartlettroscoe March 30, 2023 15:27
@lucbv lucbv marked this pull request as ready for review March 30, 2023 15:44
@lucbv lucbv requested a review from sebrowne March 30, 2023 15:44
lucbv
lucbv approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we need to make sure to have the changes in kokkos-kernels/cmake/Dependencies.cmake are replicated in the kokkos kernels repo otherwise they will get overwritten.

bartlettroscoe
bartlettroscoe approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it builds and works locally then this should be good to push.

But note that the changes kokkos-kernels will need to pulled off and submitted as a PR to the native kokkos-kernels github repo against the 'develop' branch in that repo. If you need instructions on that I can provide them.

@bartlettroscoe bartlettroscoe added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Mar 30, 2023
@trilinos-autotester trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Mar 30, 2023
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 2053
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 584
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 579
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 579
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 1822
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 1581
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 219
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Using Repos:

Repo: TRILINOS (NexGenAnalytics/Trilinos)
  • Branch: tpls-rocblas-rocsparse
  • SHA: 6b5afb3
  • Mode: TEST_REPO

Pull Request Author: mperrinel

@ndellingwood
Copy link
Contributor

This looks good, we need to make sure to have the changes in kokkos-kernels/cmake/Dependencies.cmake are replicated in the kokkos kernels repo otherwise they will get overwritten.

@lucbv we'll also need that change cherry-picked to release-candidate-4.0.01 to avoid clobbering these changes in Trilinos

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 2053
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 584
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 579
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 579
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 1822
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 1581
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 219
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11750
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH tpls-rocblas-rocsparse
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 6b5afb3
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0070613


CDash Test Results for PR# 11750.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe lucbv sebrowne ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@lucbv
Copy link
Contributor

lucbv commented Mar 30, 2023

For reference the corresponding change in Kokkos Kernels here

@lucbv lucbv merged commit d25bfcc into trilinos:develop Mar 30, 2023
@ndellingwood ndellingwood mentioned this pull request Apr 3, 2023
Merged
@lucbv lucbv mentioned this pull request May 17, 2023
Open
@jhux2 jhux2 deleted the tpls-rocblas-rocsparse branch May 17, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe

@sebrowne sebrowne

@lucbv lucbv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mperrinel @trilinos-autotester @ndellingwood @lucbv @bartlettroscoe @sebrowne