Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Belos: Fix #994 (make ICGS default orthogonalizer for GMRES) #4650

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Belos: Fix #994 (make ICGS default orthogonalizer for GMRES) #4650

merged 1 commit into from
Mar 19, 2019

Conversation

mhoemmen
Copy link
Contributor

@trilinos/belos @jjellio @hkthorn @vbrunini @iyamazaki

Description

Change Belos::PseudoBlockGmresSolMgr's default orthogonalizer from DGKS (modified Gram-Schmidt with careful checks) to ICGS (classical Gram-Schmidt, repeated unconditionally).

Motivation and Context

  1. Get better performance with default settings
  2. Make Belos behave like AztecOO out of the box

Related Issues

@mhoemmen mhoemmen added pkg: Belos results impacting Changes in the code will result changes to the outputs in a non-trivial way labels Mar 19, 2019
@mhoemmen mhoemmen self-assigned this Mar 19, 2019
@jjellio
Copy link
Contributor

jjellio commented Mar 19, 2019

I know in the past, when this came up. The idea was to provide a 'fast' set of parameters, but it seems that paradigm just doesn't work well =\

I seem to remember that DGKS doesn't performance substantially different from ICGS2. Infact, don't both perform similarly when loss of orthogonality is not detected? If the apps really want performance at the cost of accuracy, then doing ICGS1 (when they can) is the way to go for performance.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2865
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2692
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1144
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 833
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 568
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Using Repos:

Repo: TRILINOS (mhoemmen/Trilinos)
  • Branch: Fix-994
  • SHA: 57cbd3e
  • Mode: TEST_REPO

Pull Request Author: mhoemmen

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2865
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2692
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1144
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 833
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 568
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 2865 (click to expand) 

TRIBITS_DIR=/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/Trilinos/cmake/tribits

A) Generate the Trilinos Packages definition and depencencies XML file


Wrote the file 'TrilinosPackageDependencies.xml'


B) Get the set of changed files


Current directory: /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/Trilinos


git diff --name-only origin/develop..HEAD > /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/changed-files.txt


Wrote file 'changed-files.txt'


Current directory: /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4


C) Get the unfiltered list of changed Trilinos packages (including 'ALL_PACKAGES')


CHANGED_PACKAGES_FULL_LIST='Belos'


D) Filter list of changed packages to get only the PT packages


CHANGED_PACKAGES_PT_LIST='Belos'


E) Generate the *.cmake enables file


Wrote file 'packageEnables.cmake'


    

  • set +x
    
Enabled packages:
    
-- Setting Trilinos_ENABLE_Belos = ON
    
Set CWD = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/TFW_testing_single_configure_prototype
    
Build name               = PR-4650-test-Trilinos_pullrequest_gcc_4.8.4-2865
    
Cur dir                  = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/TFW_testing_single_configure_prototype
    
Source dir               = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/Trilinos
    
Binary dir               = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/pull_request_test
    
Parallel level           = 29
    
skip_by_parts_submit     = OFF
    
skip_single_submit       = ON
    
skip_update_step         = ON
    
skip_upload_config_files = OFF
    
skip_clean_build_dir     = OFF
    
Subproject count         = 53
    
Dashboard model          = Experimental
    
Dashboard track          = Pull Request
    
Running configuration:
    
/projects/sems/install/rhel7-x86_64/sems/utility/cmake/3.10.3/bin/cmake
    
-C "/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/Trilinos/cmake/std/PullRequestLinuxGCC4.8.4TestingSettings.cmake"
    
-C "/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/packageEnables.cmake"
    
-DTrilinos_ENABLE_TESTS:BOOL=ON
    
-G "Ninja"
    
/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.8.4/Trilinos
    
CTEST_DROP_LOCATION = /cdash/submit.php?project=Trilinos
    
CDash URL1 = https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&display=project&filtercount=3&showfilters=1&filtercombine=and&field1=site&compare1=61&value1=tr-test-3.novalocal&field2=buildname&compare2=61&value2=PR-4650-test-Trilinos_pullrequest_gcc_4.8.4-2865&field3=buildstamp&compare3=61&value3=20190319-0534-Pull Request
    
CDash URL2 = https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&display=project&filtercount=2&showfilters=0&filtercombine=and&field1=buildname&compare1=61&value1=PR-4650-test-Trilinos_pullrequest_gcc_4.8.4-2865&field2=buildstamp&compare2=61&value2=20190319-0534-Pull Request
    
CDash URL3 = https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&filtercount=2&showfilters=0&filtercombine=and&field1=buildname&compare1=61&value1=PR-4650-test-Trilinos_pullrequest_gcc_4.8.4-2865&field2=buildstamp&compare2=61&value2=20190319-0534-Pull Request
    
Starting configure step.
    
Each . represents 1024 bytes of output
    
..................................................  Size: 50K
    
..................................................  Size: 100K
    
..................................................  Size: 150K
    
..................................................  Size: 200K
    
............... Size of output: 214K
    
configure submit error = 0
    
Configure suceeded.
    
Starting build step.
    
Each symbol represents 1024 bytes of output.
    
..................................................  Size: 49K
    
..................................................  Size: 99K
    
..................................................  Size: 149K
    
..................................................  Size: 199K
    
..................................................  Size: 249K
    
..................................................  Size: 299K
    
..................................................  Size: 349K
    
..................................................  Size: 399K
    
..................................................  Size: 449K
    
..................................................  Size: 499K
    
..................................................  Size: 549K
    
..................................................  Size: 599K
    
..................................................  Size: 649K
    
..................................................  Size: 699K
    
..................................................  Size: 749K
    
..................................................  Size: 800K
    
..................................................  Size: 849K
    
..................................................  Size: 899K
    
..................................................  Size: 949K
    
..................................................  Size: 999K
    
..................................................  Size: 1050K
    
..................................................  Size: 1099K
    
..................................................  Size: 1150K
    
..................................................  Size: 1199K
    
..................................................  Size: 1249K
    
.... Size of output: 1254K
    
Build succeeded.
    
build submit error = 0
    
Starting testing step.
    
Tests succeeded.
    
test submit error = 0
    
File upload submit error = 0
    
Archiving artifacts
    
Finished: SUCCESS
    •
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 2692 (click to expand) 

    ..................................................  Size: 12999K
    ..................................................  Size: 13049K
    ..................................................  Size: 13099K
    ..................................................  Size: 13149K
    ..................................................  Size: 13199K
    ..................................................  Size: 13249K
    ..................................................  Size: 13299K
    ..................................................  Size: 13349K
    ..................................................  Size: 13399K
    ..................................................  Size: 13449K
    ..................................................  Size: 13500K
    ..................................................  Size: 13550K
    ..................................................  Size: 13600K
    ..................................................  Size: 13650K
    ..................................................  Size: 13699K
    ..................................................  Size: 13750K
    ..................................................  Size: 13800K
    ..................................................  Size: 13850K
    ..................................................  Size: 13900K
    ..................................................  Size: 13950K
    ..................................................  Size: 14000K
    ..................................................  Size: 14050K
    ..................................................  Size: 14100K
    ..................................................  Size: 14149K
    ..................................................  Size: 14199K
    ..................................................  Size: 14249K
    ..................................................  Size: 14300K
    ..................................................  Size: 14349K
    ..................................................  Size: 14399K
    ..................................................  Size: 14449K
    ..................................................  Size: 14499K
    ..................................................  Size: 14550K
    ..................................................  Size: 14599K
    ..................................................  Size: 14650K
    ..................................................  Size: 14700K
    ..................................................  Size: 14750K
    ..................................................  Size: 14800K
    ..................................................  Size: 14850K
    ..................................................  Size: 14900K
    ..................................................  Size: 14950K
    ..................................................  Size: 15000K
    ..................................................  Size: 15050K
    ..................................................  Size: 15100K
    ..................................................  Size: 15150K
    ..................................................  Size: 15200K
    ..................................................  Size: 15250K
    ..................................................  Size: 15300K
    ..................................................  Size: 15350K
    ..................................................  Size: 15400K
    ..................................................  Size: 15449K
    ..................................................  Size: 15499K
    ..................................................  Size: 15549K
    ..................................................  Size: 15599K
    ..................................................  Size: 15650K
    ..................................................  Size: 15700K
    ..................................................  Size: 15750K
    ..................................................  Size: 15799K
    ..................................................  Size: 15850K
    ..................................................  Size: 15899K
    ..................................................  Size: 15950K
    ..................................................  Size: 16000K
    ..................................................  Size: 16050K
    ..................................................  Size: 16100K
    ..................................................  Size: 16150K
    ..................................................  Size: 16199K
    ..................................................  Size: 16249K
    ..................................................  Size: 16299K
    ..................................................  Size: 16349K
    ..................................................  Size: 16399K
    ..................................................  Size: 16450K
    ..................................................  Size: 16500K
    ..................................................  Size: 16550K
    ..................................................  Size: 16599K
    ..................................................  Size: 16649K
    ..................................................  Size: 16700K
    ..................................................  Size: 16749K
    ..................................................  Size: 16800K
    ..................................................  Size: 16849K
    ..................................................  Size: 16900K
    ..................................................  Size: 16949K
    ..................................................  Size: 16999K
    ..................................................  Size: 17050K
    ..................................................  Size: 17099K
    ..................................................  Size: 17150K
    ..................................................  Size: 17200K
    ..................................................  Size: 17250K
    ..................................................  Size: 17299K
    ..................................................  Size: 17350K
    ..................................................  Size: 17399K
    ..................................................  Size: 17450K
    ..................................................  Size: 17500K
    .................................. Size of output: 17533K
Build succeeded.
build submit error = 0
Starting testing step.
Tests succeeded.
test submit error = 0
File upload submit error = 0
Archiving artifacts
Finished: SUCCESS
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 1144 (click to expand) 

***
*** Generating set of Trilinos enables given modified packages from
*** git commit origin/develop to HEAD
***

TRILINOS_DIR=/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3_SERIAL/Trilinos

TRILINOS_SCRIPTS_DIR=/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3_SERIAL/Trilinos

TRIBITS_DIR=/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3_SERIAL/Trilinos/cmake/tribits


A) Generate the Trilinos Packages definition and depencencies XML file


Wrote the file 'TrilinosPackageDependencies.xml'


B) Get the set of changed files


Current directory: /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3_SERIAL/Trilinos


git diff --name-only origin/develop..HEAD > /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3_SERIAL/changed-files.txt


Wrote file 'changed-files.txt'


Current directory: /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3_SERIAL


C) Get the unfiltered list of changed Trilinos packages (including 'ALL_PACKAGES')


CHANGED_PACKAGES_FULL_LIST='Belos'


D) Filter list of changed packages to get only the PT packages


CHANGED_PACKAGES_PT_LIST='Belos'


E) Generate the *.cmake enables file


Wrote file 'packageEnables.cmake'
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 833 (click to expand) 

Wrote the file 'TrilinosPackageDependencies.xml'

B) Get the set of changed files


Current directory: /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/Trilinos


git diff --name-only origin/develop..HEAD > /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/changed-files.txt


Wrote file 'changed-files.txt'


Current directory: /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0


C) Get the unfiltered list of changed Trilinos packages (including 'ALL_PACKAGES')


CHANGED_PACKAGES_FULL_LIST='Belos'


D) Filter list of changed packages to get only the PT packages


CHANGED_PACKAGES_PT_LIST='Belos'


E) Generate the *.cmake enables file


Wrote file 'packageEnables.cmake'


    

  • set +x
    
Enabled packages:
    
-- Setting Trilinos_ENABLE_Belos = ON
    
Set CWD = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/TFW_testing_single_configure_prototype
    
Build name               = PR-4650-test-Trilinos_pullrequest_gcc_7.2.0-833
    
Cur dir                  = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/TFW_testing_single_configure_prototype
    
Source dir               = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/Trilinos
    
Binary dir               = /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/pull_request_test
    
Parallel level           = 29
    
skip_by_parts_submit     = OFF
    
skip_single_submit       = ON
    
skip_update_step         = ON
    
skip_upload_config_files = OFF
    
skip_clean_build_dir     = OFF
    
Subproject count         = 53
    
Dashboard model          = Experimental
    
Dashboard track          = Pull Request
    
Running configuration:
    
/projects/sems/install/rhel7-x86_64/sems/utility/cmake/3.10.3/bin/cmake
    
-C "/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/Trilinos/cmake/std/PullRequestLinuxGCC7.2.0TestingSettings.cmake"
    
-C "/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/packageEnables.cmake"
    
-DTrilinos_ENABLE_TESTS:BOOL=ON
    
-G "Ninja"
    
/scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/Trilinos
    
CTEST_DROP_LOCATION = /cdash/submit.php?project=Trilinos
    
CDash URL1 = https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&display=project&filtercount=3&showfilters=1&filtercombine=and&field1=site&compare1=61&value1=tr-test-4.novalocal&field2=buildname&compare2=61&value2=PR-4650-test-Trilinos_pullrequest_gcc_7.2.0-833&field3=buildstamp&compare3=61&value3=20190319-0535-Pull Request
    
CDash URL2 = https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&display=project&filtercount=2&showfilters=0&filtercombine=and&field1=buildname&compare1=61&value1=PR-4650-test-Trilinos_pullrequest_gcc_7.2.0-833&field2=buildstamp&compare2=61&value2=20190319-0535-Pull Request
    
CDash URL3 = https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&filtercount=2&showfilters=0&filtercombine=and&field1=buildname&compare1=61&value1=PR-4650-test-Trilinos_pullrequest_gcc_7.2.0-833&field2=buildstamp&compare2=61&value2=20190319-0535-Pull Request
    
Starting configure step.
    
Each . represents 1024 bytes of output
    
..................................................  Size: 50K
    
..................................................  Size: 100K
    
..................................................  Size: 150K
    
..................................................  Size: 200K
    
.................... Size of output: 219K
    
configure submit error = 0
    
Configure suceeded.
    
Starting build step.
    
Each symbol represents 1024 bytes of output.
    
..................................................  Size: 49K
    
..................................................  Size: 99K
    
..................................................  Size: 149K
    
..................................................  Size: 199K
    
..................................................  Size: 249K
    
..................................................  Size: 299K
    
..................................................  Size: 350K
    
..................................................  Size: 399K
    
..................................................  Size: 449K
    
..................................................  Size: 499K
    
..................................................  Size: 549K
    
..................................................  Size: 599K
    
..................................................  Size: 649K
    
..................................................  Size: 699K
    
..................................................  Size: 749K
    
..................................................  Size: 799K
    
..................................................  Size: 849K
    
..................................................  Size: 899K
    
..................................................  Size: 949K
    
..................................................  Size: 999K
    
..................................................  Size: 1050K
    
..................................................  Size: 1099K
    
..................................................  Size: 1149K
    
..................................................  Size: 1199K
    
.............. Size of output: 1214K
    
Build succeeded.
    
build submit error = 0
    
Starting testing step.
    
CMake Error at /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_7.2.0/TFW_testing_single_configure_prototype/simple_testing.cmake:213 (message):
    
Test failed with error -1
    • 



test submit error = 0

File upload submit error = 0

Single configure/build/test failed. The error code was: 255

Build step 'Execute shell' marked build as failure

Archiving artifacts

Finished: FAILURE
Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 568 (click to expand) 

    ..................................................  Size: 13950K
    ..................................................  Size: 14000K
    ..................................................  Size: 14049K
    ..................................................  Size: 14099K
    ..................................................  Size: 14149K
    ..................................................  Size: 14199K
    ..................................................  Size: 14249K
    ..................................................  Size: 14299K
    ..................................................  Size: 14350K
    ..................................................  Size: 14400K
    ..................................................  Size: 14450K
    ..................................................  Size: 14500K
    ..................................................  Size: 14550K
    ..................................................  Size: 14600K
    ..................................................  Size: 14649K
    ..................................................  Size: 14699K
    ..................................................  Size: 14749K
    ..................................................  Size: 14799K
    ..................................................  Size: 14849K
    ..................................................  Size: 14899K
    ..................................................  Size: 14949K
    ..................................................  Size: 14999K
    ..................................................  Size: 15049K
    ..................................................  Size: 15099K
    ..................................................  Size: 15149K
    ..................................................  Size: 15199K
    ..................................................  Size: 15249K
    ..................................................  Size: 15299K
    ..................................................  Size: 15349K
    ..................................................  Size: 15399K
    ..................................................  Size: 15449K
    ..................................................  Size: 15500K
    ..................................................  Size: 15550K
    ..................................................  Size: 15600K
    ..................................................  Size: 15650K
    ..................................................  Size: 15700K
    ..................................................  Size: 15750K
    ..................................................  Size: 15800K
    ..................................................  Size: 15850K
    ..................................................  Size: 15900K
    ..................................................  Size: 15950K
    ..................................................  Size: 16000K
    ..................................................  Size: 16050K
    ..................................................  Size: 16100K
    ..................................................  Size: 16150K
    ..................................................  Size: 16199K
    ..................................................  Size: 16249K
    ..................................................  Size: 16299K
    ..................................................  Size: 16349K
    ..................................................  Size: 16399K
    ..................................................  Size: 16449K
    ..................................................  Size: 16499K
    ..................................................  Size: 16549K
    ..................................................  Size: 16599K
    ..................................................  Size: 16649K
    ..................................................  Size: 16700K
    ..................................................  Size: 16750K
    ..................................................  Size: 16800K
    ..................................................  Size: 16850K
    ..................................................  Size: 16900K
    ..................................................  Size: 16950K
    ..................................................  Size: 17000K
    ..................................................  Size: 17050K
    ..................................................  Size: 17100K
    ..................................................  Size: 17150K
    ..................................................  Size: 17200K
    ..................................................  Size: 17250K
    ..................................................  Size: 17300K
    ..................................................  Size: 17350K
    ..................................................  Size: 17400K
    ..................................................  Size: 17450K
    ..................................................  Size: 17500K
    ..................................................  Size: 17550K
    ..................................................  Size: 17600K
    ..................................................  Size: 17650K
    ..................................................  Size: 17700K
    ..................................................  Size: 17750K
    ..................................................  Size: 17800K
    ..................................................  Size: 17850K
    ..................................................  Size: 17900K
    ..................................................  Size: 17950K
    ..................................................  Size: 18000K
    ..................................................  Size: 18050K
    ..................................................  Size: 18099K
    ..................................................  Size: 18149K
    ..................................................  Size: 18200K
    ..................................................  Size: 18249K
    ..................................................  Size: 18299K
    ..................................................  Size: 18349K
    ..................................................  Size: 18400K
    ..................................................  Size: 18449K
    ............ Size of output: 18462K
Build succeeded.
build submit error = 0
Starting testing step.
Tests succeeded.
test submit error = 0
File upload submit error = 0
Archiving artifacts
Finished: SUCCESS


CDash Test Results for PR# 4650.


Wiki: How to Reproduce PR Testing Builds and Errors.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2870
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2697
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1149
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 837
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 572
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Using Repos:

Repo: TRILINOS (mhoemmen/Trilinos)
  • Branch: Fix-994
  • SHA: 57cbd3e
  • Mode: TEST_REPO

Pull Request Author: mhoemmen

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2870
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2697
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1149
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 837
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 572
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4650
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-994
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 57cbd3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a3d3a33


CDash Test Results for PR# 4650.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

cgcgcg
cgcgcg approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@cgcgcg cgcgcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always set 'ICGS' in my parameter lists anyways, so I am ok with this change. But maybe give others a chance to chime in before merging in case there are strong feelings..

@mhoemmen
Copy link
Contributor Author

mhoemmen commented Mar 19, 2019 •
edited
Loading

Thanks @cgcgcg ! I've e-mailed @hkthorn to solicit feedback, since this change may affect Anasazi users who are using Belos as the inner solver. Please don't merge this quite just yet.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@hkthorn
Copy link
Contributor

hkthorn commented Mar 19, 2019

@cgcgcg @mhoemmen As long as ICGS performs two passes, I agree to this change.

@hkthorn
Copy link
Contributor

hkthorn commented Mar 19, 2019

@cgcgcg @mhoemmen This change should be made to all the solvers that require orthogonalization for commonality. Otherwise, users will be confused why one version of GMRES uses this orthogonalization and others do not.

@mhoemmen
Copy link
Contributor Author

@hkthorn Would you prefer to make that change in the same PR or could we wait until a separate one? I've been trying to merge as soon as tests pass since PR testing has been a disaster lately.

@hkthorn
Copy link
Contributor

hkthorn commented Mar 19, 2019

@mhoemmen A separate one is fine, I just wanted to get my thought out there before it got lost.

@mhoemmen mhoemmen merged commit 1e72ab5 into trilinos:develop Mar 19, 2019
@mhoemmen mhoemmen deleted the Fix-994 branch March 19, 2019 18:13
@mhoemmen
Copy link
Contributor Author

@hkthorn Thanks!

@mhoemmen mhoemmen mentioned this pull request Mar 19, 2019
Closed
@mhoemmen
Copy link
Contributor Author

@hkthorn I filed a separate issue for changing the other GMRES-like solvers' default: #4657

@cgcgcg cgcgcg mentioned this pull request Mar 20, 2019
Closed
@jwillenbring jwillenbring mentioned this pull request Mar 20, 2019
Closed
@jennloe jennloe mentioned this pull request May 14, 2020
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgcgcg cgcgcg cgcgcg approved these changes

@csiefer2 csiefer2 Awaiting requested review from csiefer2

@DrBooom DrBooom Awaiting requested review from DrBooom

@kddevin kddevin Awaiting requested review from kddevin

@hkthorn hkthorn Awaiting requested review from hkthorn

@jjellio jjellio Awaiting requested review from jjellio

@lucbv lucbv Awaiting requested review from lucbv

Assignees

@mhoemmen mhoemmen

Labels
pkg: Belos results impacting Changes in the code will result changes to the outputs in a non-trivial way
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhoemmen @jjellio @trilinos-autotester @hkthorn @cgcgcg