MueLu: distance2 coloring, Aggregates_kokkos and Phase 1 aggregation #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1 aggregation issue trilinos#5838 Adding a set and get methods to Aggregates_kokkos in order to store the coloring of the LWGraph used for aggregates creation. This will allow to pass the colors to all phases of aggregation without reworking interfaces too much. Using the new methods in LWGraph_kokkos avoids copying on host the data needed by the coloring algorithm. This saves 2 communication: 1 DtoH and 1 HtoD. Extra time monitors are added in AggregationPhase1 to account for coloring and aggregation separately. Adding a test that exercises the Distance2 algorithmic path in test/scaling
lucbv
added
type: enhancement
lucbv
requested review from
william76,
brian-kelley,
cgcgcg,
csiefer2 and
jhux2
cgcgcg
approved these changes
Sep 4, 2019
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 5853: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/muelu
Description
Adding a set and get methods to Aggregates_kokkos in order to store the coloring of the LWGraph used for aggregates creation.
This will allow to pass the colors to all phases of aggregation without reworking interfaces too much.
Using the new methods in LWGraph_kokkos avoids copying on host the data needed by
the coloring algorithm. This saves 2 communication: 1 DtoH and 1 HtoD.
Extra time monitors are added in AggregationPhase1 to account for coloring and
aggregation separately.
Adding a test that exercises the Distance2 algorithmic path in test/scaling
Motivation and Context
This work is part of a refactor to have MueLu SA-AMG setup performed on device
Related Issues
How Has This Been Tested?
I did a local build with OpenMP, all the test pass including the new test for Distance2 with the
scaling/DriverChecklist